Hi Thomas, On 4/19/19 9:56 AM, Thomas Huth wrote: > First patch fixes a problem with ohci_die(), second patch moves PCI code into > a separate file, so that the sysbus OHCI device can also be used without > the dependency on the PCI code. > > v2: Split the patch into two patches, one for the ohci_die() fix and one > for the PCI code movement.
Way cleaner. I wonder why you don't use a typedef for the void (*ohci_die_fn)(struct OHCIState *) prototype. Anyway to this series: Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com> Tested-by: Philippe Mathieu-Daudé <phi...@redhat.com> > > Thomas Huth (2): > hw/usb/hcd-ohci: Do not use PCI functions with sysbus devices in > ohci_die() > hw/usb/hcd-ohci: Move PCI-related code into a separate file > > hw/sh4/Kconfig | 2 +- > hw/usb/Kconfig | 6 +- > hw/usb/Makefile.objs | 1 + > hw/usb/hcd-ohci-pci.c | 163 +++++++++++++++++++++++++++++++ > hw/usb/hcd-ohci.c | 219 ++++-------------------------------------- > hw/usb/hcd-ohci.h | 104 ++++++++++++++++++++ > 6 files changed, 293 insertions(+), 202 deletions(-) > create mode 100644 hw/usb/hcd-ohci-pci.c > create mode 100644 hw/usb/hcd-ohci.h >
