26.04.2019 21:30, Max Reitz wrote: > On 15.04.19 16:49, Vladimir Sementsov-Ogievskiy wrote: >> Split out cluster_size calculation. Move copy-bitmap creation above >> block-job creation, as we are going to share it with upcoming >> backup-top filter, which also should be created before actual block job >> creation. >> >> Also, while being here, drop unnecessary "goto error" from >> bdrv_getlength error path. > > It isn’t unnecessary, though. Before this, we invoke > bdrv_dirty_bitmap_create_successor(), so the error path has to clean > that up with bdrv_reclaim_dirty_bitmap(). > > Max >
Oops, will resend. I was looking at previous plain "return NULL", but missed that in "if" branch we do thing to be rolled-back on fail. Thank you for review! -- Best regards, Vladimir
