Patchew URL: https://patchew.org/QEMU/20190429090250.7648-1-borntrae...@de.ibm.com/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190429090250.7648-1-borntrae...@de.ibm.com Subject: [Qemu-devel] [PATCH v3 0/9] s390x: new guest features === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190426221528.30293-1-js...@redhat.com -> patchew/20190426221528.30293-1-js...@redhat.com t [tag update] patchew/20190427162922.4207-1-f4...@amsat.org -> patchew/20190427162922.4207-1-f4...@amsat.org * [new tag] patchew/20190429090250.7648-1-borntrae...@de.ibm.com -> patchew/20190429090250.7648-1-borntrae...@de.ibm.com Switched to a new branch 'test' 99081a4e07 s390x/cpumodel: wire up 8561 and 8562 as gen15 machines f36b5e963f s390x/cpumodel: add gen15 defintions 469d33aadf s390x/cpumodel: add Deflate-conversion facility d08509db86 s390x/cpumodel: enhanced sort facility fb2ea624ba s390x/cpumodel: vector enhancements 409ba7ad54 s390x/cpumodel: msa9 facility 3658d6287f s390x/cpumodel: Miscellaneous-Instruction-Extensions Facility 3 7e144efffc s390x/cpumodel: ignore csske for expansion 10af5a5a9c linux header sync === OUTPUT BEGIN === 1/9 Checking commit 10af5a5a9cec (linux header sync) 2/9 Checking commit 7e144efffc8c (s390x/cpumodel: ignore csske for expansion) 3/9 Checking commit 3658d6287fa9 (s390x/cpumodel: Miscellaneous-Instruction-Extensions Facility 3) ERROR: line over 90 characters #22: FILE: target/s390x/cpu_features.c:86: + FEAT_INIT("minste3", S390_FEAT_TYPE_STFL, 61, "Miscellaneous-Instruction-Extensions Facility 3"), total: 1 errors, 0 warnings, 14 lines checked Patch 3/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/9 Checking commit 409ba7ad5446 (s390x/cpumodel: msa9 facility) ERROR: line over 90 characters #22: FILE: target/s390x/cpu_features.c:111: + FEAT_INIT("msa9-base", S390_FEAT_TYPE_STFL, 155, "Message-security-assist-extension-9 facility (excluding subfunctions)"), WARNING: line over 80 characters #30: FILE: target/s390x/cpu_features.c:246: + FEAT_INIT("pckmo-ecc-p256", S390_FEAT_TYPE_PCKMO, 32, "PCKMO Encrypt-ECC-P256-Key"), WARNING: line over 80 characters #31: FILE: target/s390x/cpu_features.c:247: + FEAT_INIT("pckmo-ecc-p384", S390_FEAT_TYPE_PCKMO, 33, "PCKMO Encrypt-ECC-P384-Key"), WARNING: line over 80 characters #32: FILE: target/s390x/cpu_features.c:248: + FEAT_INIT("pckmo-ecc-p521", S390_FEAT_TYPE_PCKMO, 34, "PCKMO Encrypt-ECC-P521-Key"), ERROR: line over 90 characters #33: FILE: target/s390x/cpu_features.c:249: + FEAT_INIT("pckmo-ecc-ed25519", S390_FEAT_TYPE_PCKMO, 40 , "PCKMO Encrypt-ECC-Ed25519-Key"), ERROR: line over 90 characters #34: FILE: target/s390x/cpu_features.c:250: + FEAT_INIT("pckmo-ecc-ed448", S390_FEAT_TYPE_PCKMO, 41 , "PCKMO Encrypt-ECC-Ed448-Key"), WARNING: line over 80 characters #42: FILE: target/s390x/cpu_features.c:307: + FEAT_INIT("pcc-scalar-mult-p256", S390_FEAT_TYPE_PCC, 64, "PCC Scalar-Multiply-P256"), WARNING: line over 80 characters #43: FILE: target/s390x/cpu_features.c:308: + FEAT_INIT("pcc-scalar-mult-p384", S390_FEAT_TYPE_PCC, 65, "PCC Scalar-Multiply-P384"), WARNING: line over 80 characters #44: FILE: target/s390x/cpu_features.c:309: + FEAT_INIT("pcc-scalar-mult-p521", S390_FEAT_TYPE_PCC, 66, "PCC Scalar-Multiply-P521"), ERROR: line over 90 characters #45: FILE: target/s390x/cpu_features.c:310: + FEAT_INIT("pcc-scalar-mult-ed25519", S390_FEAT_TYPE_PCC, 72, "PCC Scalar-Multiply-Ed25519"), ERROR: line over 90 characters #46: FILE: target/s390x/cpu_features.c:311: + FEAT_INIT("pcc-scalar-mult-ed448", S390_FEAT_TYPE_PCC, 73, "PCC Scalar-Multiply-Ed448"), ERROR: line over 90 characters #47: FILE: target/s390x/cpu_features.c:312: + FEAT_INIT("pcc-scalar-mult-x25519", S390_FEAT_TYPE_PCC, 80, "PCC Scalar-Multiply-X25519"), WARNING: line over 80 characters #48: FILE: target/s390x/cpu_features.c:313: + FEAT_INIT("pcc-scalar-mult-x448", S390_FEAT_TYPE_PCC, 81, "PCC Scalar-Multiply-X448"), WARNING: line over 80 characters #57: FILE: target/s390x/cpu_features.c:326: + FEAT_INIT("kdsa-ecdsa-verify-p256", S390_FEAT_TYPE_KDSA, 1, "KDSA ECDSA-Verify-P256"), WARNING: line over 80 characters #58: FILE: target/s390x/cpu_features.c:327: + FEAT_INIT("kdsa-ecdsa-verify-p384", S390_FEAT_TYPE_KDSA, 2, "KDSA ECDSA-Verify-P384"), WARNING: line over 80 characters #59: FILE: target/s390x/cpu_features.c:328: + FEAT_INIT("kdsa-ecdsa-verify-p521", S390_FEAT_TYPE_KDSA, 3, "KDSA ECDSA-Verify-P521"), WARNING: line over 80 characters #60: FILE: target/s390x/cpu_features.c:329: + FEAT_INIT("kdsa-ecdsa-sign-p256", S390_FEAT_TYPE_KDSA, 9, "KDSA ECDSA-Sign-P256"), WARNING: line over 80 characters #61: FILE: target/s390x/cpu_features.c:330: + FEAT_INIT("kdsa-ecdsa-sign-p384", S390_FEAT_TYPE_KDSA, 10, "KDSA ECDSA-Sign-P384"), WARNING: line over 80 characters #62: FILE: target/s390x/cpu_features.c:331: + FEAT_INIT("kdsa-ecdsa-sign-p521", S390_FEAT_TYPE_KDSA, 11, "KDSA ECDSA-Sign-P521"), ERROR: line over 90 characters #63: FILE: target/s390x/cpu_features.c:332: + FEAT_INIT("kdsa-eecdsa-sign-p256", S390_FEAT_TYPE_KDSA, 17, "KDSA Encrypted-ECDSA-Sign-P256"), ERROR: line over 90 characters #64: FILE: target/s390x/cpu_features.c:333: + FEAT_INIT("kdsa-eecdsa-sign-p384", S390_FEAT_TYPE_KDSA, 18, "KDSA Encrypted-ECDSA-Sign-P384"), ERROR: line over 90 characters #65: FILE: target/s390x/cpu_features.c:334: + FEAT_INIT("kdsa-eecdsa-sign-p521", S390_FEAT_TYPE_KDSA, 19, "KDSA Encrypted-ECDSA-Sign-P521"), ERROR: line over 90 characters #66: FILE: target/s390x/cpu_features.c:335: + FEAT_INIT("kdsa-eddsa-verify-ed25519", S390_FEAT_TYPE_KDSA, 32, "KDSA EdDSA-Verify-Ed25519"), ERROR: line over 90 characters #67: FILE: target/s390x/cpu_features.c:336: + FEAT_INIT("kdsa-eddsa-verify-ed448", S390_FEAT_TYPE_KDSA, 36, "KDSA EdDSA-Verify-Ed448"), ERROR: line over 90 characters #68: FILE: target/s390x/cpu_features.c:337: + FEAT_INIT("kdsa-eddsa-sign-ed25519", S390_FEAT_TYPE_KDSA, 40, "KDSA EdDSA-Sign-Ed25519"), WARNING: line over 80 characters #69: FILE: target/s390x/cpu_features.c:338: + FEAT_INIT("kdsa-eddsa-sign-ed448", S390_FEAT_TYPE_KDSA, 44, "KDSA EdDSA-Sign-Ed448"), ERROR: line over 90 characters #70: FILE: target/s390x/cpu_features.c:339: + FEAT_INIT("kdsa-eeddsa-sign-ed25519", S390_FEAT_TYPE_KDSA, 48, "KDSA Encrypted-EdDSA-Sign-Ed25519"), ERROR: line over 90 characters #71: FILE: target/s390x/cpu_features.c:340: + FEAT_INIT("kdsa-eeddsa-sign-ed448", S390_FEAT_TYPE_KDSA, 52, "KDSA Encrypted-EdDSA-Sign-Ed448"), WARNING: line over 80 characters #87: FILE: target/s390x/cpu_features.c:499: + FEAT_GROUP_INIT("msa9", MSA_EXT_9, "Message-security-assist-extension 9 facility"), ERROR: line over 90 characters #88: FILE: target/s390x/cpu_features.c:500: + FEAT_GROUP_INIT("msa9_pckmo", MSA_EXT_9_PCKMO, "Message-security-assist-extension 9 PCKMO subfunctions"), ERROR: Macros with complex values should be enclosed in parenthesis #188: FILE: target/s390x/gen-features.c:216: +#define S390_FEAT_GROUP_MSA_EXT_9 \ + S390_FEAT_MSA_EXT_9, \ + S390_FEAT_ECDSA_VERIFY_P256, \ + S390_FEAT_ECDSA_VERIFY_P384, \ + S390_FEAT_ECDSA_VERIFY_P512, \ + S390_FEAT_ECDSA_SIGN_P256, \ + S390_FEAT_ECDSA_SIGN_P384, \ + S390_FEAT_ECDSA_SIGN_P512, \ + S390_FEAT_EECDSA_SIGN_P256, \ + S390_FEAT_EECDSA_SIGN_P384, \ + S390_FEAT_EECDSA_SIGN_P512, \ + S390_FEAT_EDDSA_VERIFY_ED25519, \ + S390_FEAT_EDDSA_VERIFY_ED448, \ + S390_FEAT_EDDSA_SIGN_ED25519, \ + S390_FEAT_EDDSA_SIGN_ED448, \ + S390_FEAT_EEDDSA_SIGN_ED25519, \ + S390_FEAT_EEDDSA_SIGN_ED448, \ + S390_FEAT_PCC_SCALAR_MULT_P256, \ + S390_FEAT_PCC_SCALAR_MULT_P384, \ + S390_FEAT_PCC_SCALAR_MULT_P512, \ + S390_FEAT_PCC_SCALAR_MULT_ED25519, \ + S390_FEAT_PCC_SCALAR_MULT_ED448, \ + S390_FEAT_PCC_SCALAR_MULT_X25519, \ + S390_FEAT_PCC_SCALAR_MULT_X448 ERROR: Macros with complex values should be enclosed in parenthesis #213: FILE: target/s390x/gen-features.c:241: +#define S390_FEAT_GROUP_MSA_EXT_9_PCKMO \ + S390_FEAT_PCKMO_ECC_P256, \ + S390_FEAT_PCKMO_ECC_P384, \ + S390_FEAT_PCKMO_ECC_P521, \ + S390_FEAT_PCKMO_ECC_ED25519, \ + S390_FEAT_PCKMO_ECC_ED448 total: 17 errors, 15 warnings, 216 lines checked Patch 4/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/9 Checking commit fb2ea624ba0b (s390x/cpumodel: vector enhancements) WARNING: line over 80 characters #21: FILE: target/s390x/cpu_features.c:111: + FEAT_INIT("vxeh2", S390_FEAT_TYPE_STFL, 148, "Vector Enhancements facility 2"), WARNING: line over 80 characters #22: FILE: target/s390x/cpu_features.c:112: + FEAT_INIT("vxbeh", S390_FEAT_TYPE_STFL, 152, "Vector BCD enhancements facility 1"), total: 0 errors, 2 warnings, 16 lines checked Patch 5/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/9 Checking commit d08509db86ef (s390x/cpumodel: enhanced sort facility) ERROR: line over 90 characters #21: FILE: target/s390x/cpu_features.c:112: + FEAT_INIT("esort-base", S390_FEAT_TYPE_STFL, 150, "Enhanced-sort facility (excluding subfunctions)"), WARNING: line over 80 characters #34: FILE: target/s390x/cpu_features.c:349: + FEAT_INIT("sortl-f0", S390_FEAT_TYPE_SORTL, 192, "SORTL format 0 parameter-block"), ERROR: Macros with complex values should be enclosed in parenthesis #108: FILE: target/s390x/gen-features.c:248: +#define S390_FEAT_GROUP_ENH_SORT \ + S390_FEAT_ESORT_BASE, \ + S390_FEAT_SORTL_SFLR, \ + S390_FEAT_SORTL_SVLR, \ + S390_FEAT_SORTL_32, \ + S390_FEAT_SORTL_128, \ + S390_FEAT_SORTL_F0 total: 2 errors, 1 warnings, 117 lines checked Patch 6/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/9 Checking commit 469d33aadfc7 (s390x/cpumodel: add Deflate-conversion facility) ERROR: line over 90 characters #20: FILE: target/s390x/cpu_features.c:113: + FEAT_INIT("deflate-base", S390_FEAT_TYPE_STFL, 151, "Deflate-conversion facility (excluding subfunctions)"), WARNING: line over 80 characters #32: FILE: target/s390x/cpu_features.c:355: + FEAT_INIT("dfltcc-f0", S390_FEAT_TYPE_DFLTCC, 192, "DFLTCC format 0 parameter-block"), WARNING: line over 80 characters #56: FILE: target/s390x/cpu_features.c:522: + FEAT_GROUP_INIT("deflate", DEFLATE_CONVERSION, "Deflate-conversion facility"), ERROR: Macros with complex values should be enclosed in parenthesis #105: FILE: target/s390x/gen-features.c:257: +#define S390_FEAT_GROUP_DEFLATE_CONVERSION \ + S390_FEAT_DEFLATE_BASE, \ + S390_FEAT_DEFLATE_GHDT, \ + S390_FEAT_DEFLATE_CMPR, \ + S390_FEAT_DEFLATE_XPND, \ + S390_FEAT_DEFLATE_F0 total: 2 errors, 2 warnings, 113 lines checked Patch 7/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/9 Checking commit f36b5e963f12 (s390x/cpumodel: add gen15 defintions) 9/9 Checking commit 99081a4e072a (s390x/cpumodel: wire up 8561 and 8562 as gen15 machines) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190429090250.7648-1-borntrae...@de.ibm.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
