On 4/30/19 1:13 PM, Cao Jiaxi wrote: > Signed-off-by: Cao Jiaxi <driver1...@foxmail.com>
Your entire series is missing 'In-Reply-To:' and 'References:' headers, making each message show up as individual new threads rather than properly threaded to a 0/4 cover letter. You'll want to fix your sending habits to avoid that problem in future submissions. It's unusual to use a trailing '.' in the subject line. Also, your subject is very long; commit message summaries should typically be around 60-70 characters because 'git log' shows them with further indentation, where an 80-column terminal window makes it hard to see the tail at a glance. Better might be a short subject line explaining the "what", and then a non-empty commit message explaining the "why", perhaps looking like: osdep: Fix mingw compilation regarding stdio formats I encountered the following compilation error on mingw: ... PASTE SOMETHING HERE It turns out that __USE_MINGW_ANSI_STDIO must be set before any system headers are included, not just before <stdio.h>. Signed-off-by:... > > +/* enable C99/POSIX format strings (needs mingw32-runtime 3.15 or later) */ > +#ifdef __MINGW32__ > +#define __USE_MINGW_ANSI_STDIO 1 > +#endif > + > #include <stdarg.h> > #include <stddef.h> > #include <stdbool.h> > #include <stdint.h> > #include <sys/types.h> > #include <stdlib.h> > - > -/* enable C99/POSIX format strings (needs mingw32-runtime 3.15 or later) */ > -#ifdef __MINGW32__ > -#define __USE_MINGW_ANSI_STDIO 1 > -#endif Question - does it hurt to make the define of __USE_MINGW_ANSI_STDIO unconditional? In other words, we're unlikely to break any non-mingw platform if we drop the #ifdef __MINGW32__ line. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
