On 5/2/19 4:05 PM, driver1998 wrote: > On 5/1/19 2:30 AM, Eric Blake wrote: >> Your entire series is missing 'In-Reply-To:' and 'References:' headers, >> making each message show up as individual new threads rather than >> properly threaded to a 0/4 cover letter. You'll want to fix your sending >> habits to avoid that problem in future submissions. > > I am terribly sorry about that, this is the first time I summit patches, and > I am still getting used to the tooling.
That's okay, we were all first-timers once; and most human maintainers try to be more forgiving than automated tools when it comes to working around first-timer learning curves. There may be other useful hints you can use at https://wiki.qemu.org/Contribute/SubmitAPatch > Thank you for pointing out the issue though. > >> It's unusual to use a trailing '.' in the subject line. Also, your >> subject is very long; commit message summaries should typically be >> around 60-70 characters because 'git log' shows them with further >> indentation, where an 80-column terminal window makes it hard to see the >> tail at a glance. Better might be a short subject line explaining the >> "what", and then a non-empty commit message explaining the "why" > > Thank you for pointing out, I'll update that in the upcoming v3 set. > >> Question - does it hurt to make the define of __USE_MINGW_ANSI_STDIO >> unconditional? In other words, we're unlikely to break any non-mingw >> platform if we drop the #ifdef __MINGW32__ line. > > I personally have no idea, so I'll keep it as is. Fair enough for your patch. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature