On 30/04/2019 20.13, Cao Jiaxi wrote: > Windows ARM64 uses LLP64 model, which breaks current assumptions. > > Signed-off-by: Cao Jiaxi <driver1...@foxmail.com> > --- > util/cacheinfo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/util/cacheinfo.c b/util/cacheinfo.c > index 3cd080b83d..ce6f0dbf6a 100644 > --- a/util/cacheinfo.c > +++ b/util/cacheinfo.c > @@ -107,7 +107,7 @@ static void sys_cache_info(int *isize, int *dsize) > static void arch_cache_info(int *isize, int *dsize) > { > if (*isize == 0 || *dsize == 0) { > - unsigned long ctr; > + uintptr_t ctr;
Looking at the whole function, is uintptr_t really the right type to use here? ctr does not seem to contain the value of a pointer variable, so this looks wrong to me... Do you get a compiler warning here? If so, how does it look like? Anyway, I think it would be better to use a uint64_t or uint32_t type here instead if possible? Thomas