On Fri, May 10, 2019 at 04:02:56PM +0100, Mark Cave-Ayland wrote: > On 09/05/2019 01:49, Anton Blanchard wrote: > > > We were using set_cpu_vsr*() when we should have used get_cpu_vsr*(). > > > > Fixes: 8b3b2d75c7c0 ("introduce get_cpu_vsr{l,h}() and set_cpu_vsr{l,h}() > > helpers for VSR register access") > > Signed-off-by: Anton Blanchard <an...@ozlabs.org> > > --- > > target/ppc/translate/vsx-impl.inc.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/target/ppc/translate/vsx-impl.inc.c > > b/target/ppc/translate/vsx-impl.inc.c > > index b487136d52..4b7627f53b 100644 > > --- a/target/ppc/translate/vsx-impl.inc.c > > +++ b/target/ppc/translate/vsx-impl.inc.c > > @@ -859,8 +859,8 @@ static void glue(gen_, name)(DisasContext *ctx) > > \ > > xbh = tcg_temp_new_i64(); \ > > xbl = tcg_temp_new_i64(); \ > > sgm = tcg_temp_new_i64(); \ > > - set_cpu_vsrh(xB(ctx->opcode), xbh); \ > > - set_cpu_vsrl(xB(ctx->opcode), xbl); \ > > + get_cpu_vsrh(xbh, xB(ctx->opcode)); \ > > + get_cpu_vsrl(xbl, xB(ctx->opcode)); \ > > tcg_gen_movi_i64(sgm, sgn_mask); \ > > switch (op) { \ > > case OP_ABS: { \ > > Reviewed-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk>
Applied, thanks. > > > ATB, > > Mark. > -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature