Peter Maydell <peter.mayd...@linaro.org> writes: > On Thu, 23 May 2019 at 09:15, Markus Armbruster <arm...@redhat.com> wrote: >> >> Signed-off-by: Markus Armbruster <arm...@redhat.com> >> --- > >> 432 files changed, 1035 insertions(+), 8 deletions(-) >> >> diff --git a/accel/tcg/atomic_template.h b/accel/tcg/atomic_template.h >> index 685602b076..352da0c745 100644 >> --- a/accel/tcg/atomic_template.h >> +++ b/accel/tcg/atomic_template.h >> @@ -18,6 +18,9 @@ >> * License along with this library; if not, see >> <http://www.gnu.org/licenses/>. >> */ >> >> +/* NOTE: May only be included into target-dependent code */ >> +/* FIXME Does not pass make check-headers, yet! */ >> + > > I'm not sure I see much point in touching several hundred > header files just to add a FIXME note. We can fix them, > or we can just leave things as they are...
Adding FIXMEs without an intent to actually fix them would be stupid. The FIXMEs direct "make check-headers" to skip the headers so marked. Without the FIXMEs, "make check-headers" fails. I want it to succeed, so we can run it from "make check", and gain protection against clean headers becoming unclean. What "make check-headers" covers is for us to choose. This RFC series starts with include/, then widens to everything in two big steps: * PATCH 5: include/. 764 headers, 179 known-bad. * PATCH 6: all of the source tree. Adds 797 headers, 409 known-bad. * PATCH 7: plus generated headers. Adds 177 headers, 3 known-bad. We can start smaller, and take smaller steps.
