On Fri, 24 May 2019 at 13:25, Markus Armbruster <arm...@redhat.com> wrote: > > Peter Maydell <peter.mayd...@linaro.org> writes: > > > On Thu, 23 May 2019 at 09:15, Markus Armbruster <arm...@redhat.com> wrote: > >> > >> Signed-off-by: Markus Armbruster <arm...@redhat.com> > >> --- > > > >> 432 files changed, 1035 insertions(+), 8 deletions(-) > >> > >> diff --git a/accel/tcg/atomic_template.h b/accel/tcg/atomic_template.h > >> index 685602b076..352da0c745 100644 > >> --- a/accel/tcg/atomic_template.h > >> +++ b/accel/tcg/atomic_template.h > >> @@ -18,6 +18,9 @@ > >> * License along with this library; if not, see > >> <http://www.gnu.org/licenses/>. > >> */ > >> > >> +/* NOTE: May only be included into target-dependent code */ > >> +/* FIXME Does not pass make check-headers, yet! */ > >> + > > > > I'm not sure I see much point in touching several hundred > > header files just to add a FIXME note. We can fix them, > > or we can just leave things as they are... > > Adding FIXMEs without an intent to actually fix them would be stupid. > > The FIXMEs direct "make check-headers" to skip the headers so marked.
Ah, right. It wasn't clear that this is a directive to the script: it looks like the usual free-text aimed-at-human-readers kind of FIXME/TODO comment. thanks -- PMM