On 04/18/11 17:02, Michael Roth wrote:
> These apply on top of Anthony's glib tree, commit
> 03d5927deb5e6baebaade1b4c8ff2428a85e125c currently, and can also be obtained
> from:
> git://repo.or.cz/qemu/mdroth.git qga_v2
>
> Patches 1-8 are general json/QAPI-related fixes. Anthony, please consider
> pulling these into your glib tree. The json fix-ups may need further
> evaluation, but I'm confident they're at least an improvement. The QAPI ones
> are mostly trivial fix-ups.
>
> Changes since V1:
>
> - Added guest agent worker thread to execute RPCs in the guest. With this in
> place we have a reliable timeout mechanism for hung commands, currently set
> at 30 seconds.
> - Add framework for registering init/cleanup routines for stateful RPCs to
> clean up after themselves after a timeout.
> - Added the following RPCs: guest-file-{open,close,read,write,seek},
> guest-shutdown, guest-info, and removed stubs for guest-view-file (now
> deprecated)
> - Added GUEST_AGENT_UP/GUEST_AGENT_DOWN QMP events
> - Switched to a TCP-style host-initiated 3-way handshake for channel
> negotiation, this simplifies client negotiation/interaction over the wire
> - Added configurable log level/log file/pid file options for guest agent
> - Various fixes for bugs/memory leaks and checkpatch.pl fixups
>
> ISSUES/TODOS:
>
> - Fix QMP proxy handling of error responses sent by guest agent, currently
> ignored
> - Add unit tests for guest agent wire protocol
> - Add unit tests for QMP interfaces
> - Add host-side timeout mechanism for async QMP commands
> - Return error for guest commands if guest up event has not yet been recieved
> - Make QMP param names more consistent between related commands
> - Clean up logging
>
Hi,
I had a look through this patchset and generally it looks pretty good.
There were a few nits, and I ignored all the python gibberish to avoid
getting a headache.
Did you do anything with the fsfreeze patches, or were they dropped in
the migration to qapi?
Cheers,
Jes
