On Wed, 29 May 2019 at 13:48, Markus Armbruster <arm...@redhat.com> wrote: > > Peter Maydell <peter.mayd...@linaro.org> writes: > > fpu/softfloat-specialize.h is a bit odd as it's intended to be included > > exactly once, by fpu/softfloat.c. Guards wouldn't hurt, I think, but it > > might be cleanest to rename it to fpu/softfloat-specialize.inc.c > > to match our convention for "lump of C which is textually > > included but isn't a header". > > Makes me wonder why we bother with a separate file.
Partly historical, because all the fpu/ code is originally third-party from the softfloat project. Partly it separates out "code which may need to be adjusted with ifdefs to implement target-specific behaviour" from "code that should be target-agnostic". thanks -- PMM
