Patchew URL: https://patchew.org/QEMU/20190604203351.27778-1-richard.hender...@linaro.org/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v4 00/39] tcg: Move the softmmu tlb to CPUNegativeOffsetState Message-id: 20190604203351.27778-1-richard.hender...@linaro.org === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Switched to a new branch 'test' f8596dd tcg/arm: Remove mostly unreachable tlb special case 603a5f1 tcg/arm: Use LDRD to load tlb mask+table 836bf0a tcg/aarch64: Use LDP to load tlb mask+table e39d70a cpu: Remove CPU_COMMON 793f779 cpu: Move the softmmu tlb to CPUNegativeOffsetState d66f2a6 cpu: Move icount_decr to CPUNegativeOffsetState 6722835 cpu: Introduce CPUNegativeOffsetState 78b8d55 cpu: Introduce cpu_set_cpustate_pointers c2fa081 cpu: Move ENV_OFFSET to exec/gen-icount.h 858f454 target/xtensa: Use env_cpu, env_archcpu f9249cd target/unicore32: Use env_cpu, env_archcpu 9ecd17a target/tricore: Use env_cpu 531b2be target/tilegx: Use env_cpu a442964 target/sparc: Use env_cpu, env_archcpu 48b5b70 target/sh4: Use env_cpu, env_archcpu 73c66b0 target/s390x: Use env_cpu, env_archcpu bd8ef3c target/riscv: Use env_cpu, env_archcpu 1dc6031 target/ppc: Use env_cpu, env_archcpu b2fba00 target/openrisc: Use env_cpu, env_archcpu 365bbce target/nios2: Use env_cpu, env_archcpu facb326 target/moxie: Use env_cpu, env_archcpu 2824611 target/mips: Use env_cpu, env_archcpu 6127245 target/microblaze: Use env_cpu, env_archcpu b281c56 target/m68k: Use env_cpu, env_archcpu 5a5aa1b target/lm32: Use env_cpu, env_archcpu 1c115e8 target/i386: Use env_cpu, env_archcpu 34f7d2a target/hppa: Use env_cpu, env_archcpu ea4a53f target/cris: Use env_cpu, env_archcpu 132f302 target/cris: Reindent op_helper.c 53c1580 target/cris: Reindent mmu.c 0192671 target/arm: Use env_cpu, env_archcpu 085f0f9 target/alpha: Use env_cpu, env_archcpu 632858f cpu: Introduce env_archcpu 1731a35 cpu: Replace ENV_GET_CPU with env_cpu 71904ca cpu: Define ArchCPU 24cceb2 cpu: Define CPUArchState with typedef 7b5100a tcg: Create struct CPUTLB 10c5f06 tcg: Split out target/arch/cpu-param.h 54a7978 tcg: Fold CPUTLBWindow into CPUTLBDesc === OUTPUT BEGIN === 1/39 Checking commit 54a79782c553 (tcg: Fold CPUTLBWindow into CPUTLBDesc) 2/39 Checking commit 10c5f068daa9 (tcg: Split out target/arch/cpu-param.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #57: new file mode 100644 total: 0 errors, 1 warnings, 1290 lines checked Patch 2/39 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/39 Checking commit 7b5100a1e548 (tcg: Create struct CPUTLB) 4/39 Checking commit 24cceb2507f0 (cpu: Define CPUArchState with typedef) 5/39 Checking commit 71904cac5402 (cpu: Define ArchCPU) 6/39 Checking commit 1731a359fc4d (cpu: Replace ENV_GET_CPU with env_cpu) 7/39 Checking commit 632858f72759 (cpu: Introduce env_archcpu) 8/39 Checking commit 085f0f97e81e (target/alpha: Use env_cpu, env_archcpu) 9/39 Checking commit 019267126056 (target/arm: Use env_cpu, env_archcpu) 10/39 Checking commit 53c1580d3402 (target/cris: Reindent mmu.c) 11/39 Checking commit 132f3025c6b8 (target/cris: Reindent op_helper.c) 12/39 Checking commit ea4a53fb0c7e (target/cris: Use env_cpu, env_archcpu) 13/39 Checking commit 34f7d2a1d8b6 (target/hppa: Use env_cpu, env_archcpu) 14/39 Checking commit 1c115e846a49 (target/i386: Use env_cpu, env_archcpu) 15/39 Checking commit 5a5aa1b9bb77 (target/lm32: Use env_cpu, env_archcpu) 16/39 Checking commit b281c56f03d4 (target/m68k: Use env_cpu, env_archcpu) 17/39 Checking commit 612724572942 (target/microblaze: Use env_cpu, env_archcpu) 18/39 Checking commit 2824611f1148 (target/mips: Use env_cpu, env_archcpu) 19/39 Checking commit facb3268b3bb (target/moxie: Use env_cpu, env_archcpu) 20/39 Checking commit 365bbce9fef3 (target/nios2: Use env_cpu, env_archcpu) 21/39 Checking commit b2fba00c41f5 (target/openrisc: Use env_cpu, env_archcpu) 22/39 Checking commit 1dc603161cc7 (target/ppc: Use env_cpu, env_archcpu) 23/39 Checking commit bd8ef3ceddf1 (target/riscv: Use env_cpu, env_archcpu) 24/39 Checking commit 73c66b0b626c (target/s390x: Use env_cpu, env_archcpu) 25/39 Checking commit 48b5b7034c82 (target/sh4: Use env_cpu, env_archcpu) 26/39 Checking commit a4429646576d (target/sparc: Use env_cpu, env_archcpu) 27/39 Checking commit 531b2be29199 (target/tilegx: Use env_cpu) 28/39 Checking commit 9ecd17ac00cb (target/tricore: Use env_cpu) 29/39 Checking commit f9249cddf5c0 (target/unicore32: Use env_cpu, env_archcpu) 30/39 Checking commit 858f4545b2e4 (target/xtensa: Use env_cpu, env_archcpu) 31/39 Checking commit c2fa081c8850 (cpu: Move ENV_OFFSET to exec/gen-icount.h) 32/39 Checking commit 78b8d55c2e2a (cpu: Introduce cpu_set_cpustate_pointers) 33/39 Checking commit 67228358c01d (cpu: Introduce CPUNegativeOffsetState) 34/39 Checking commit d66f2a670d00 (cpu: Move icount_decr to CPUNegativeOffsetState) ERROR: return is not a function, parentheses are not required #193: FILE: cpus.c:242: + return (cpu->icount_budget - total: 1 errors, 0 warnings, 326 lines checked Patch 34/39 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 35/39 Checking commit 793f779666d8 (cpu: Move the softmmu tlb to CPUNegativeOffsetState) 36/39 Checking commit e39d70a9a542 (cpu: Remove CPU_COMMON) 37/39 Checking commit 836bf0a1d1f7 (tcg/aarch64: Use LDP to load tlb mask+table) 38/39 Checking commit 603a5f195f37 (tcg/arm: Use LDRD to load tlb mask+table) 39/39 Checking commit f8596dd63bd4 (tcg/arm: Remove mostly unreachable tlb special case) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190604203351.27778-1-richard.hender...@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com