Patchew URL: https://patchew.org/QEMU/20190617184903.19436-1-arm...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PULL 00/16] Monitor patches for 2019-06-17 Type: series Message-id: 20190617184903.19436-1-arm...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20190617175317.27557-1-peter.mayd...@linaro.org -> patchew/20190617175317.27557-1-peter.mayd...@linaro.org Switched to a new branch 'test' 10cbb82 vl: Deprecate -mon pretty=... for HMP monitors c8d6357 monitor: Replace monitor_init() with monitor_init_{hmp, qmp}() add28d5 monitor: Split Monitor.flags into separate bools 61f535a monitor: Split out monitor/monitor.c 1f84df4 monitor: Split out monitor/hmp.c 7b0f436 monitor: Split out monitor/qmp.c 62fff9a monitor: Create monitor-internal.h with common definitions 0be87c8 monitor: Move {hmp, qmp}.c to monitor/{hmp, qmp}-cmds.c 9dc5b85 Move monitor.c to monitor/misc.c 32b2352 monitor: Rename HMP command type and tables 6259cf7 monitor: Remove Monitor.cmd_table indirection 4cc8716 monitor: Create MonitorHMP with readline state e28b9ba monitor: Make MonitorQMP a child class of Monitor 0032c2c monitor: Split monitor_init in HMP and QMP function 8ef4253 monitor: Remove unused password prompting fields f21701f monitor: Fix return type of monitor_fdset_dup_fd_find === OUTPUT BEGIN === 1/16 Checking commit f21701f2afc2 (monitor: Fix return type of monitor_fdset_dup_fd_find) 2/16 Checking commit 8ef4253a4478 (monitor: Remove unused password prompting fields) 3/16 Checking commit 0032c2cf455d (monitor: Split monitor_init in HMP and QMP function) 4/16 Checking commit e28b9ba8e716 (monitor: Make MonitorQMP a child class of Monitor) 5/16 Checking commit 4cc8716de54a (monitor: Create MonitorHMP with readline state) 6/16 Checking commit 6259cf7f6c52 (monitor: Remove Monitor.cmd_table indirection) 7/16 Checking commit 32b235292bf6 (monitor: Rename HMP command type and tables) 8/16 Checking commit 9dc5b85526e4 (Move monitor.c to monitor/misc.c) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #82: new file mode 100644 total: 0 errors, 1 warnings, 78 lines checked Patch 8/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/16 Checking commit 0be87c866744 (monitor: Move {hmp, qmp}.c to monitor/{hmp, qmp}-cmds.c) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #106: rename from hmp.c total: 0 errors, 1 warnings, 73 lines checked Patch 9/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/16 Checking commit 62fff9aeab3c (monitor: Create monitor-internal.h with common definitions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #227: new file mode 100644 total: 0 errors, 1 warnings, 326 lines checked Patch 10/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/16 Checking commit 7b0f43601c81 (monitor: Split out monitor/qmp.c) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #628: new file mode 100644 total: 0 errors, 1 warnings, 984 lines checked Patch 11/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/16 Checking commit 1f84df448bda (monitor: Split out monitor/hmp.c) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #33: new file mode 100644 ERROR: consider using qemu_strtoull in preference to strtoull #436: FILE: monitor/hmp.c:399: + n = strtoull(pch, &p, 0); total: 1 errors, 1 warnings, 2937 lines checked Patch 12/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/16 Checking commit 61f535a02231 (monitor: Split out monitor/monitor.c) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #735: new file mode 100644 WARNING: Block comments use a leading /* on a separate line #1370: FILE: monitor/monitor.c:631: + { /* end of list */ } total: 0 errors, 2 warnings, 1317 lines checked Patch 13/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/16 Checking commit add28d51ab77 (monitor: Split Monitor.flags into separate bools) 15/16 Checking commit c8d635777789 (monitor: Replace monitor_init() with monitor_init_{hmp, qmp}()) 16/16 Checking commit 10cbb82deaa5 (vl: Deprecate -mon pretty=... for HMP monitors) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190617184903.19436-1-arm...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com