On Mon, Jun 17, 2019 at 08:49:03PM +0200, Markus Armbruster wrote: > From: Kevin Wolf <kw...@redhat.com> > > The -mon pretty=on|off switch of the -mon option applies only to QMP > monitors. It's silently ignored for HMP. Deprecate this combination so > that we can make it an error in future versions.
No objection to merging this PR as is, but how about we extend the deprecation to QMP too ? I was responsible for adding this option back in 2010 and I don't think I've used it since 2012 when I added pretty printing support to scripts/qmp/qmp-shell. I struggle to imagine good reasons for using QMP directly with pretty printing, as opposed to doing it via qmp-shell or another wrapper tool. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
