On 10.07.19 03:05, John Snow wrote: > Signed-off-by: John Snow <js...@redhat.com> > --- > tests/qemu-iotests/257 | 31 + > tests/qemu-iotests/257.out | 3089 ++++++++++++++++++++++++++++++++++++ > 2 files changed, 3120 insertions(+)
Oof.
> diff --git a/tests/qemu-iotests/257 b/tests/qemu-iotests/257
> index de8707cb19..8de1c4da19 100755
> --- a/tests/qemu-iotests/257
> +++ b/tests/qemu-iotests/257
[...]
> @@ -410,6 +416,11 @@ def test_bitmap_sync(bsync_mode, msync_mode='bitmap',
> failure=None):
> if bsync_mode == 'always' and failure == 'intermediate':
> # We manage to copy one sector (one bit) before the error.
> ebitmap.clear_bit(ebitmap.first_bit)
> + if msync_mode in ('full', 'top'):
> + # These modes return all bits set except what was
> copied/skipped
Hm. How useful is bitmap support for 'top' then, anyway? That means
that if you want to resume a top backup, you always have to resume it
like it was a full backup. Which sounds kind of useless.
Max
> + fail_bit = ebitmap.first_bit
> + ebitmap.clear()
> + ebitmap.dirty_bits(range(fail_bit, SIZE // GRANULARITY))
> ebitmap.compare(get_bitmap(bitmaps, drive0.device, 'bitmap0'))
>
> # 2 - Writes and Reference Backup
[...]
signature.asc
Description: OpenPGP digital signature
