On 7/10/19 12:22 PM, Max Reitz wrote:
> On 10.07.19 03:05, John Snow wrote:
>> Signed-off-by: John Snow <js...@redhat.com>
>> ---
>> tests/qemu-iotests/257 | 69 +++++++++++++++++++++++++++++++
>> tests/qemu-iotests/257.out | 85 ++++++++++++++++++++++++++++++++++++++
>> 2 files changed, 154 insertions(+)
>>
>> diff --git a/tests/qemu-iotests/257 b/tests/qemu-iotests/257
>> index 2eb4f26c28..de8707cb19 100755
>> --- a/tests/qemu-iotests/257
>> +++ b/tests/qemu-iotests/257
>> @@ -450,10 +450,79 @@ def test_bitmap_sync(bsync_mode, msync_mode='bitmap',
>> failure=None):
>> compare_images(img_path, fbackup2)
>> log('')
>>
>> +def test_backup_api():
>> + """
>> + """
>
> Er, OK?
>
> [...]
>
Whooooooooops.
>> + for sync_mode, config in error_cases.items():
>> + log("-- Sync mode {:s} tests --\n".format(sync_mode))
>> + for bitmap, policies in config.items():
>
> You might be interested in the fact that the iteration order is
> different for Python2. Or maybe you aren’t.
>
asdf. This is undoubtedly the worst thing about Python. I'll have to fix
this, because the ordering isn't guaranteed until 3.5 or some such and
we're only EOLing Python2.
--js