Patchew URL: https://patchew.org/QEMU/cover.1563224628.git.dirty.ice...@gmail.com/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: cover.1563224628.git.dirty.ice...@gmail.com Type: series Subject: [Qemu-devel] [PATCH v2 00/14] Multiple simultaneous audio backends === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 9bd8bc6 audio: fix memory leak reported by ASAN e8d23f6 audio: use size_t where makes sense 7035d9f audio: remove read and write pcm_ops 82038f1 paaudio: fix playback glitches ad773f9 audio: do not run each backend in audio_run e5bae54 audio: remove audio_MIN, audio_MAX 3f525e4 paaudio: properly disconnect streams in fini_* e76429c paaudio: do not move stream when sink/source name is specified 232f925 audio: audiodev= parameters no longer optional when -audiodev present 0475ef4 paaudio: prepare for multiple audiodev d0ccdb3 audio: add audiodev properties to frontends b8bbf6b audio: add audiodev property to vnc and wav_capture 45bece9 audio: basic support for multi backend audio b8ed8fa audio: reduce glob_audio_state usage === OUTPUT BEGIN === 1/14 Checking commit b8ed8fa72e64 (audio: reduce glob_audio_state usage) 2/14 Checking commit 45bece9445ff (audio: basic support for multi backend audio) 3/14 Checking commit b8bbf6b1534a (audio: add audiodev property to vnc and wav_capture) 4/14 Checking commit d0ccdb31831d (audio: add audiodev properties to frontends) 5/14 Checking commit 0475ef4aa556 (paaudio: prepare for multiple audiodev) 6/14 Checking commit 232f925703f4 (audio: audiodev= parameters no longer optional when -audiodev present) 7/14 Checking commit e76429c12dda (paaudio: do not move stream when sink/source name is specified) 8/14 Checking commit 3f525e459011 (paaudio: properly disconnect streams in fini_*) 9/14 Checking commit e5bae54fc748 (audio: remove audio_MIN, audio_MAX) ERROR: space prohibited between function name and open parenthesis '(' #23: FILE: audio/alsaaudio.c:637: + int len = MIN (alsa->pending, left_till_end_samples); ERROR: space prohibited between function name and open parenthesis '(' #32: FILE: audio/alsaaudio.c:700: + decr = MIN (live, avail); ERROR: space prohibited between function name and open parenthesis '(' #41: FILE: audio/alsaaudio.c:918: + decr = MIN (dead, avail); ERROR: space prohibited between function name and open parenthesis '(' #54: FILE: audio/audio.c:536: + m = MIN (m, sw->total_hw_samples_acquired); ERROR: space prohibited between function name and open parenthesis '(' #63: FILE: audio/audio.c:556: + int len = MIN (left, live); ERROR: space prohibited between function name and open parenthesis '(' #71: FILE: audio/audio.c:563: + int samples_to_clip = MIN (len, samples_till_end_of_buf); ERROR: space prohibited between function name and open parenthesis '(' #80: FILE: audio/audio.c:617: + swlim = MIN (swlim, samples); ERROR: space prohibited between function name and open parenthesis '(' #89: FILE: audio/audio.c:665: + m = MIN (m, sw->total_hw_samples_mixed); ERROR: space prohibited between function name and open parenthesis '(' #98: FILE: audio/audio.c:728: + swlim = MIN (swlim, samples); ERROR: space prohibited between function name and open parenthesis '(' #107: FILE: audio/audio.c:740: + blck = MIN (dead, left); ERROR: space prohibited between function name and open parenthesis '(' #116: FILE: audio/audio.c:1032: + int to_write = MIN (till_end_of_hw, n); ERROR: space prohibited between function name and open parenthesis '(' #125: FILE: audio/audio.c:1050: + n = MIN (samples, hw->samples - rpos); ERROR: space prohibited between function name and open parenthesis '(' #134: FILE: audio/audio.c:1206: + int to_capture = MIN (live, left); ERROR: space prohibited between function name and open parenthesis '(' #175: FILE: audio/coreaudio.c:416: + decr = MIN (core->decr, live); ERROR: space prohibited between function name and open parenthesis '(' #188: FILE: audio/dsoundaudio.c:710: + len = MIN (len, dead); ERROR: space prohibited between function name and open parenthesis '(' #206: FILE: audio/noaudio.c:59: + decr = MIN (live, samples); ERROR: space prohibited between function name and open parenthesis '(' #215: FILE: audio/noaudio.c:114: + bytes = MIN (bytes, INT_MAX); ERROR: space prohibited between function name and open parenthesis '(' #218: FILE: audio/noaudio.c:116: + samples = MIN (samples, dead); ERROR: space prohibited between function name and open parenthesis '(' #227: FILE: audio/noaudio.c:127: + int to_clear = MIN (samples, total); ERROR: space prohibited between function name and open parenthesis '(' #240: FILE: audio/ossaudio.c:391: + int samples_to_write = MIN (oss->pending, samples_till_end); ERROR: space prohibited between function name and open parenthesis '(' #249: FILE: audio/ossaudio.c:440: + decr = MIN (bytes >> hw->info.shift, live); ERROR: space prohibited between function name and open parenthesis '(' #258: FILE: audio/ossaudio.c:459: + decr = MIN (abinfo.bytes >> hw->info.shift, live); ERROR: space prohibited between function name and open parenthesis '(' #280: FILE: audio/paaudio.c:247: + int chunk = MIN (to_mix, hw->samples - rpos); ERROR: space prohibited between function name and open parenthesis '(' #289: FILE: audio/paaudio.c:285: + decr = MIN (live, pa->decr); ERROR: space prohibited between function name and open parenthesis '(' #307: FILE: audio/paaudio.c:339: + int chunk = MIN (to_grab, hw->samples - wpos); ERROR: space prohibited between function name and open parenthesis '(' #316: FILE: audio/paaudio.c:378: + incr = MIN (dead, pa->incr); ERROR: space prohibited between function name and open parenthesis '(' #342: FILE: audio/sdlaudio.c:239: + decr = MIN (sdl->decr, live); ERROR: space prohibited between function name and open parenthesis '(' #355: FILE: audio/spiceaudio.c:167: + decr = MIN (live, decr); ERROR: space prohibited between function name and open parenthesis '(' #362: FILE: audio/spiceaudio.c:173: + int len = MIN (samples, left_till_end_samples); ERROR: space prohibited between function name and open parenthesis '(' #370: FILE: audio/spiceaudio.c:180: + len = MIN (len, out->fsize); ERROR: space prohibited between function name and open parenthesis '(' #379: FILE: audio/spiceaudio.c:298: + num_samples = MIN (num_samples, delta_samp); ERROR: space prohibited between function name and open parenthesis '(' #388: FILE: audio/spiceaudio.c:308: + num_samples = MIN (ready, num_samples); ERROR: space prohibited between function name and open parenthesis '(' #401: FILE: audio/wavaudio.c:62: + decr = MIN (live, samples); ERROR: space prohibited between function name and open parenthesis '(' #407: FILE: audio/wavaudio.c:67: + int convert_samples = MIN (samples, left_till_end_samples); ERROR: space prohibited between function name and open parenthesis '(' #420: FILE: hw/audio/ac97.c:967: + temp = MIN (temp, max); ERROR: space prohibited between function name and open parenthesis '(' #429: FILE: hw/audio/ac97.c:976: + to_copy = MIN (temp, sizeof (tmpbuf)); ERROR: space prohibited between function name and open parenthesis '(' #429: FILE: hw/audio/ac97.c:976: + to_copy = MIN (temp, sizeof (tmpbuf)); ERROR: space prohibited between function name and open parenthesis '(' #438: FILE: hw/audio/ac97.c:1022: + int temp = MIN (elapsed, sizeof (s->silence)); ERROR: space prohibited between function name and open parenthesis '(' #438: FILE: hw/audio/ac97.c:1022: + int temp = MIN (elapsed, sizeof (s->silence)); ERROR: space prohibited between function name and open parenthesis '(' #447: FILE: hw/audio/ac97.c:1043: + temp = MIN (temp, max); ERROR: space prohibited between function name and open parenthesis '(' #456: FILE: hw/audio/ac97.c:1052: + to_copy = MIN (temp, sizeof (tmpbuf)); ERROR: space prohibited between function name and open parenthesis '(' #456: FILE: hw/audio/ac97.c:1052: + to_copy = MIN (temp, sizeof (tmpbuf)); ERROR: space prohibited between function name and open parenthesis '(' #469: FILE: hw/audio/adlib.c:198: + to_play = MIN (s->left, samples); ERROR: space prohibited between function name and open parenthesis '(' #478: FILE: hw/audio/adlib.c:213: + samples = MIN (samples, s->samples - s->pos); ERROR: space prohibited between function name and open parenthesis '(' #491: FILE: hw/audio/cs4231a.c:538: + to_copy = MIN (temp, left); ERROR: space prohibited between function name and open parenthesis '(' #500: FILE: hw/audio/cs4231a.c:581: + copy = MIN (till, copy); ERROR: space prohibited between function name and open parenthesis '(' #513: FILE: hw/audio/es1370.c:648: + int temp = MIN (max, MIN (left, csc_bytes)); ERROR: space prohibited between function name and open parenthesis '(' #513: FILE: hw/audio/es1370.c:648: + int temp = MIN (max, MIN (left, csc_bytes)); ERROR: space prohibited between function name and open parenthesis '(' #522: FILE: hw/audio/es1370.c:657: + to_copy = MIN ((size_t) temp, sizeof (tmpbuf)); ERROR: space prohibited between function name and open parenthesis '(' #522: FILE: hw/audio/es1370.c:657: + to_copy = MIN ((size_t) temp, sizeof (tmpbuf)); ERROR: space prohibited between function name and open parenthesis '(' #531: FILE: hw/audio/es1370.c:675: + to_copy = MIN ((size_t) temp, sizeof (tmpbuf)); ERROR: space prohibited between function name and open parenthesis '(' #531: FILE: hw/audio/es1370.c:675: + to_copy = MIN ((size_t) temp, sizeof (tmpbuf)); ERROR: space prohibited between function name and open parenthesis '(' #544: FILE: hw/audio/gus.c:120: + to_play = MIN (samples, s->left); ERROR: space prohibited between function name and open parenthesis '(' #553: FILE: hw/audio/gus.c:135: + samples = MIN (samples, s->samples); ERROR: space prohibited between function name and open parenthesis '(' #562: FILE: hw/audio/gus.c:195: + int to_copy = MIN ((size_t) left, sizeof (tmpbuf)); ERROR: space prohibited between function name and open parenthesis '(' #562: FILE: hw/audio/gus.c:195: + int to_copy = MIN ((size_t) left, sizeof (tmpbuf)); ERROR: space prohibited between function name and open parenthesis '(' #692: FILE: hw/audio/sb16.c:1171: + to_copy = MIN (temp, left); total: 57 errors, 0 warnings, 559 lines checked Patch 9/14 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/14 Checking commit ad773f9083fd (audio: do not run each backend in audio_run) 11/14 Checking commit 82038f13a873 (paaudio: fix playback glitches) 12/14 Checking commit 7035d9f79802 (audio: remove read and write pcm_ops) 13/14 Checking commit e8d23f670a27 (audio: use size_t where makes sense) ERROR: space prohibited between function name and open parenthesis '(' #62: FILE: audio/alsaaudio.c:871: + size_t live = audio_pcm_hw_get_live_in (hw); ERROR: space prohibited between function name and open parenthesis '(' #91: FILE: audio/audio.c:529: +static size_t audio_pcm_hw_find_min_in (HWVoiceIn *hw) ERROR: space prohibited between function name and open parenthesis '(' #109: FILE: audio/audio.c:544: + size_t live = hw->total_samples_captured - audio_pcm_hw_find_min_in (hw); ERROR: space prohibited between function name and open parenthesis '(' #126: FILE: audio/audio.c:556: + size_t len = MIN (left, live); ERROR: space prohibited between function name and open parenthesis '(' #135: FILE: audio/audio.c:563: + size_t samples_to_clip = MIN (len, samples_till_end_of_buf); ERROR: space prohibited between function name and open parenthesis '(' #210: FILE: audio/audio.c:652: +static size_t audio_pcm_hw_find_min_out (HWVoiceOut *hw, int *nb_livep) ERROR: space prohibited between function name and open parenthesis '(' #223: FILE: audio/audio.c:669: +static size_t audio_pcm_hw_get_live_out (HWVoiceOut *hw, int *nb_live) WARNING: line over 80 characters #253: FILE: audio/audio.c:696: + size_t hwsamples, samples, isamp, osamp, wpos, live, dead, left, swlim, blck; ERROR: space prohibited between function name and open parenthesis '(' #301: FILE: audio/audio.c:964: +static size_t audio_get_avail (SWVoiceIn *sw) ERROR: space prohibited between function name and open parenthesis '(' #409: FILE: audio/audio.c:1066: + dolog ("live=%zu hw->samples=%zu\n", live, hw->samples); ERROR: space prohibited between function name and open parenthesis '(' #795: FILE: audio/noaudio.c:109: + bytes = MIN (bytes, SIZE_MAX); ERROR: space prohibited between function name and open parenthesis '(' #886: FILE: audio/ossaudio.c:723: + size_t live = audio_pcm_hw_get_live_in (hw); ERROR: space prohibited between function name and open parenthesis '(' #981: FILE: audio/paaudio.c:247: + size_t chunk = MIN (to_mix, hw->samples - rpos); ERROR: space prohibited between function name and open parenthesis '(' #1011: FILE: audio/paaudio.c:334: + size_t chunk = MIN (to_grab, hw->samples - wpos); ERROR: space prohibited between function name and open parenthesis '(' #1135: FILE: audio/spiceaudio.c:156: +static size_t line_out_run (HWVoiceOut *hw, size_t live) WARNING: line over 80 characters #1201: FILE: include/sysemu/replay.h:184: +void replay_audio_in(size_t *recorded, void *samples, size_t *wpos, size_t size); total: 14 errors, 2 warnings, 1106 lines checked Patch 13/14 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/14 Checking commit 9bd8bc6a283d (audio: fix memory leak reported by ASAN) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/cover.1563224628.git.dirty.ice...@gmail.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com