On 7/25/19 11:46 PM, tony.ngu...@bt.com wrote: > No-op SIZE_MEMOP macro allows us to later easily convert > memory_region_dispatch_{read|write} paramter "unsigned size" into a > size+sign+endianness encoded "MemOp op". > > Being a no-op macro, this patch does not introduce any logical change. > > Signed-off-by: Tony Nguyen <tony.ngu...@bt.com> > Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com> > --- > exec.c | 6 ++++-- > memory_ldst.inc.c | 18 +++++++++--------- > 2 files changed, 13 insertions(+), 11 deletions(-)
Reviewed-by: Richard Henderson <richard.hender...@linaro.org> > /* I/O case */ > - r = memory_region_dispatch_read(mr, addr1, &val, 4, attrs); > + r = memory_region_dispatch_read(mr, addr1, &val, SIZE_MEMOP(4), > attrs); MO_32, eventually, as well as > - r = memory_region_dispatch_read(mr, addr1, &val, 8, attrs); > + r = memory_region_dispatch_read(mr, addr1, &val, SIZE_MEMOP(8), > attrs); MO_64 > - r = memory_region_dispatch_read(mr, addr1, &val, 1, attrs); > + r = memory_region_dispatch_read(mr, addr1, &val, SIZE_MEMOP(1), > attrs); MO_8 > - r = memory_region_dispatch_read(mr, addr1, &val, 2, attrs); > + r = memory_region_dispatch_read(mr, addr1, &val, SIZE_MEMOP(2), > attrs); MO_16, and so on. r~