On 7/26/19 2:26 AM, Paolo Bonzini wrote:
> On 26/07/19 08:47, tony.ngu...@bt.com wrote:
>> + op = SIZE_MEMOP(size);
>> + if (need_bswap(big_endian)) {
>> + op ^= MO_BSWAP;
>> + }
>
> And this has the same issue as the first version. It should be
>
> op = SIZE_MEMOP(size) | (big_endian ? MO_BE : MO_LE);
>
> and everything should work. If it doesn't (and indeed it doesn't :)) it
> means you have bugs somewhere else.
As I mentioned against patch 9, which also touches this area, it should be
using the MemOp that is already passed in to this function instead of building
a new one from scratch.
But, yes, any failure in that would mean bugs somewhere else. ;-)
r~
