Eduardo Habkost <ehabk...@redhat.com> writes: > On Fri, Jul 26, 2019 at 02:05:36PM +0200, Markus Armbruster wrote: >> hw/boards.h pulls in almost 60 headers. The less we include it into >> headers, the better. As a first step, drop superfluous inclusions, >> and downgrade some more to what's actually needed. Gets rid of just >> one inclusion into a header. >> >> Cc: Eduardo Habkost <ehabk...@redhat.com> >> Cc: Marcel Apfelbaum <marcel.apfelb...@gmail.com> >> Signed-off-by: Markus Armbruster <arm...@redhat.com> > [...] >> diff --git a/hw/core/machine.c b/hw/core/machine.c >> index c58a8e594e..2c9c93983a 100644 >> --- a/hw/core/machine.c >> +++ b/hw/core/machine.c >> @@ -15,7 +15,6 @@ >> #include "qapi/qmp/qerror.h" >> #include "sysemu/replay.h" >> #include "qemu/units.h" >> -#include "hw/boards.h" >> #include "qapi/error.h" >> #include "qapi/qapi-visit-common.h" >> #include "qapi/visitor.h" > > This doesn't look right. hw/core/machine.c contains the > implementation of most functions declared at hw/boards.h, and > surely requires struct MachineClass and struct MachineState to be > defined.
Editing accident, reverted in the next patch. Harmless, because we still get it indirectly. Will drop the hunk from this patch. Thanks!
