On 8/23/19 8:39 AM, Peter Maydell wrote: >> +static bool op_bfx(DisasContext *s, arg_UBFX *a, bool u) >> +{ >> + TCGv_i32 tmp; >> + int width = a->widthm1 + 1; >> + int shift = a->lsb; >> + >> + if (!ENABLE_ARCH_6T2) { >> + return false; >> + } >> + >> + tmp = load_reg(s, a->rn); >> + if (shift + width > 32) { >> + return false; > > This UNDEF check should go before we > generate any code with the load_reg().
Oops, yep. r~