CCing qemu-triv...@nongnu.org Reviewed-by: Gonglei <arei.gong...@huawei.com>
Regards, -Gonglei > -----Original Message----- > From: Vladimir Sementsov-Ogievskiy [mailto:vsement...@virtuozzo.com] > Sent: Thursday, November 28, 2019 3:46 AM > To: qemu-devel@nongnu.org > Cc: Gonglei (Arei) <arei.gong...@huawei.com>; marcandre.lur...@gmail.com; > phi...@redhat.com; vsement...@virtuozzo.com > Subject: [PATCH v6] backends/cryptodev: drop local_err from > cryptodev_backend_complete() > > No reason for local_err here, use errp directly instead. > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> > Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com> > Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com> > --- > > v6: add r-b by Philippe and Marc-André > > backends/cryptodev.c | 11 +---------- > 1 file changed, 1 insertion(+), 10 deletions(-) > > diff --git a/backends/cryptodev.c b/backends/cryptodev.c index > 3c071eab95..5a9735684e 100644 > --- a/backends/cryptodev.c > +++ b/backends/cryptodev.c > @@ -176,19 +176,10 @@ cryptodev_backend_complete(UserCreatable *uc, > Error **errp) { > CryptoDevBackend *backend = CRYPTODEV_BACKEND(uc); > CryptoDevBackendClass *bc = CRYPTODEV_BACKEND_GET_CLASS(uc); > - Error *local_err = NULL; > > if (bc->init) { > - bc->init(backend, &local_err); > - if (local_err) { > - goto out; > - } > + bc->init(backend, errp); > } > - > - return; > - > -out: > - error_propagate(errp, local_err); > } > > void cryptodev_backend_set_used(CryptoDevBackend *backend, bool used) > -- > 2.21.0