29.11.2019 9:10, Markus Armbruster wrote:
> Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> writes:
>
>> No reason for local_err here, use errp directly instead.
>
> Related: "[PATCH v6] hw/vfio/ap: drop local_err from vfio_ap_realize".
> I'm surprised it's just two. Did you search for the anti-pattern
> systematically?
As I remember - no, only where it breaks automation. Here empty "out: }"
label will break compilation, if not fixed before or after coccinelle
run. So, here I fixed it before.
>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com>
>> Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>
>> Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com>
>> ---
>>
>> v6: add r-b by Philippe and Marc-André
>>
>> backends/cryptodev.c | 11 +----------
>> 1 file changed, 1 insertion(+), 10 deletions(-)
>>
>> diff --git a/backends/cryptodev.c b/backends/cryptodev.c
>> index 3c071eab95..5a9735684e 100644
>> --- a/backends/cryptodev.c
>> +++ b/backends/cryptodev.c
>> @@ -176,19 +176,10 @@ cryptodev_backend_complete(UserCreatable *uc, Error
>> **errp)
>> {
>> CryptoDevBackend *backend = CRYPTODEV_BACKEND(uc);
>> CryptoDevBackendClass *bc = CRYPTODEV_BACKEND_GET_CLASS(uc);
>> - Error *local_err = NULL;
>>
>> if (bc->init) {
>> - bc->init(backend, &local_err);
>> - if (local_err) {
>> - goto out;
>> - }
>> + bc->init(backend, errp);
>> }
>> -
>> - return;
>> -
>> -out:
>> - error_propagate(errp, local_err);
>> }
>>
>> void cryptodev_backend_set_used(CryptoDevBackend *backend, bool used)
>
> Reviewed-by: Markus Armbruster <arm...@redhat.com>
>
--
Best regards,
Vladimir
