> Am 30.11.2019 um 20:42 schrieb Markus Armbruster <arm...@redhat.com>: > > cpu_model_from_info() is a helper for qmp_query_cpu_model_expansion(), > qmp_query_cpu_model_comparison(), qmp_query_cpu_model_baseline(). It > crashes when the visitor or the QOM setter fails, and its @errp > argument is null. Messed up in commit 137974cea3 's390x/cpumodel: > implement QMP interface "query-cpu-model-expansion"'. > > Its three callers have the same bug. Messed up in commit 4e82ef0502 > 's390x/cpumodel: implement QMP interface "query-cpu-model-comparison"' > and commit f1a47d08ef 's390x/cpumodel: implement QMP interface > "query-cpu-model-baseline"'. > > The bugs can't bite as no caller actually passes null. Fix them > anyway.
https://en.m.wikipedia.org/wiki/Software_bug „ A software bug is an error, flaw or fault in a computer program or system that causes it to produce an incorrect or unexpected result, or to behave in unintended ways. „ Please make it clear in the descriptions that these are cleanups and not bugfixes. It might be very confusing for people looking out for real bugs. Also, please change the terminology „messed up“ to „introduced in“ or similar. (applies to all s390x patches) Thanks.
