On Sat, 30 Nov 2019 20:42:36 +0100 Markus Armbruster <arm...@redhat.com> wrote:
I don't really want to restart the discussion :), but what about: > cpu_model_from_info() is a helper for qmp_query_cpu_model_expansion(), > qmp_query_cpu_model_comparison(), qmp_query_cpu_model_baseline(). It > crashes when the visitor or the QOM setter fails, and its @errp > argument is null. "It would crash when the visitor or the QOM setter fails if its @errp argument were NULL." ? (Hope I got my conditionals right...) > Messed up in commit 137974cea3 's390x/cpumodel: I agree that "Introduced" is a bit nicer than "Messed up". > implement QMP interface "query-cpu-model-expansion"'. > > Its three callers have the same bug. Messed up in commit 4e82ef0502 > 's390x/cpumodel: implement QMP interface "query-cpu-model-comparison"' > and commit f1a47d08ef 's390x/cpumodel: implement QMP interface > "query-cpu-model-baseline"'. If we agree, I can tweak the various commit messages for the s390x patches and apply them. > The bugs can't bite as no caller actually passes null. Fix them > anyway. > > Cc: David Hildenbrand <da...@redhat.com> > Cc: Cornelia Huck <coh...@redhat.com> > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > target/s390x/cpu_models.c | 43 ++++++++++++++++++++++++--------------- > 1 file changed, 27 insertions(+), 16 deletions(-) David, I don't think you gave a R-b for that one yet?
