On 30.11.19 20:42, Markus Armbruster wrote: > get_max_cpu_model() crashes when kvm_s390_get_host_cpu_model() fails > and its @errp argument is null. > > apply_cpu_model() crashes when kvm_s390_apply_cpu_model() fails and > its @errp argument is null. > > s390_realize_cpu_model() crashes when get_max_cpu_model() or > check_compatibility() fail, and its @errp argument is null. > > All three messed up in commit 80560137cf "s390x/cpumodel: check and > apply the CPU model". > > The bugs can't bite as no caller actually passes null. Fix them > anyway. >
Subject is wrong, should e.g., start with "s390x/cpumodels". (I am not aware of CPU modules :) ) [...] Same comment regarding "local_err" and "BUG". Reviewed-by: David Hildenbrand <da...@redhat.com> -- Thanks, David / dhildenb
