David Hildenbrand <da...@redhat.com> writes:
> On 30.11.19 20:42, Markus Armbruster wrote:
>> s390x-cpu property setters set_feature() and set_feature_group() crash
>> when the visitor fails and its @errp argument is null. Messed up in
>> commit 0754f60429 "s390x/cpumodel: expose features and feature groups
>> as properties".
>
> Same comment as to the other patches :)
>
> I think we usually use "s390x/cpumodels", but that's just nitpicking.
$ git-log --oneline target/s390x/cpu_models.c | awk '$2 ~ /:$/ { print $2 }' |
sort | uniq -c
1 S390:
6 qapi:
1 qemu-common:
1 qmp:
2 qobject:
1 qom:
1 s390/cpumodel:
1 s390x/ccw:
21 s390x/cpumodel:
1 s390x/cpumodels:
1 s390x/kvm:
4 s390x/tcg:
7 s390x:
1 target/s390x/cpu_models:
17 target/s390x:
1 target:
You're right, except for the plural vs. singular. I should've browsed
git-log.
> Reviewed-by: David Hildenbrand <da...@redhat.com>
Thanks!
