Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> writes:
> 30.11.2019 22:42, Markus Armbruster wrote:
>> Cc: "Daniel P. Berrangé" <berra...@redhat.com>
>> Signed-off-by: Markus Armbruster <arm...@redhat.com>
>> ---
>> include/io/task.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/io/task.h b/include/io/task.h
>> index 5cb9faf9f2..1abbfb8b65 100644
>> --- a/include/io/task.h
>> +++ b/include/io/task.h
>> @@ -119,7 +119,7 @@ typedef void (*QIOTaskWorker)(QIOTask *task,
>> * gboolean myobject_operation_timer(gpointer opaque)
>> * {
>> * QIOTask *task = QIO_TASK(opaque);
>> - * Error *err;*
>> + * Error *err = NULL;
>> *
>> * ...check something important...
>> * if (err) {
>>
>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com>
>
> (I also think you can safely s/Fix Error usage/Fix typo/ in subject)
I'd say it's both: the trailing * is clearly a typo, but the missing
initializer is asking Murphy for random crashes at inopportune times.
Examples better set *good* examples :)
Thanks!
