Eric Blake <ebl...@redhat.com> writes: > On 12/5/19 11:46 AM, Vladimir Sementsov-Ogievskiy wrote: >> The local_err parameter is not here to return information about >> nbd_iter_channel_error failure. Instead it's assumed to be filled when >> passed to the function. This is already stressed by its name >> (local_err, instead of classic errp). Stress it additionally by >> assertion. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> >> --- >> block/nbd.c | 1 + >> 1 file changed, 1 insertion(+) > > Our timing resulted in crossed mails - I was replying to v7 when this > landed, and my reply there is still relevant (namely, a better commit > message is needed, but the code gets my R-b with that change).
If v8 turns out to be fine except for commit message tweaks, I'll gladly to these in my tree. Just tell me what to do in a reply to this message.
