On Fri, Nov 22, 2019 at 07:29:39PM +0100, Eric Auger wrote:
> build_iort(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms)
> {
> @@ -426,13 +437,12 @@ build_iort(GArray *table_data, BIOSLinker *linker,
> VirtMachineState *vms)
> smmu->gerr_gsiv = cpu_to_le32(irq + 2);
> smmu->sync_gsiv = cpu_to_le32(irq + 3);
>
> - /* Identity RID mapping covering the whole input RID range */
> - idmap = &smmu->id_mapping_array[0];
> - idmap->input_base = 0;
> - idmap->id_count = cpu_to_le32(0xFFFF);
> - idmap->output_base = 0;
> - /* output IORT node is the ITS group node (the first node) */
> - idmap->output_reference = cpu_to_le32(iort_node_offset);
> + /*
> + * Identity RID mapping covering the whole input RID range.
> + * The output IORT node is the ITS group node (the first node).
> + */
> + fill_iort_idmap(smmu->id_mapping_array, 0, 0, 0xffff, 0,
nit: the other calls use uppercase hex digits
Reviewed-by: Jean-Philippe Brucker <jean-phili...@linaro.org>
