On 2019/12/11 15:48, Laurent Vivier wrote:
> On 11/12/2019 01:55, pannengy...@huawei.com wrote:
>> From: Pan Nengyuan <pannengy...@huawei.com>
>>
>> Spotted by ASAN.
>>
>> Reported-by: Euler Robot <euler.ro...@huawei.com>
>> Signed-off-by: Pan Nengyuan <pannengy...@huawei.com>
>> ---
>> tests/vhost-user-test.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c
>> index 91ea373..54be931 100644
>> --- a/tests/vhost-user-test.c
>> +++ b/tests/vhost-user-test.c
>> @@ -717,6 +717,8 @@ static void test_migrate(void *obj, void *arg,
>> QGuestAllocator *alloc)
>> guint64 size;
>>
>> if (!wait_for_fds(s)) {
>> + g_free(uri);
>> + test_server_free(dest);
>> return;
>> }
>>
>
> Don't we need also a g_string_free(dest_cmdline)?
>
> I think it is also missing at the end of the function.
>
Yes, you are right. But I'm surprised that it hasn't been detected by asan.
I will continue to try it and send a new version.
> Thanks,
> Laurent
>
>
