* Philippe Mathieu-Daudé ([email protected]) wrote: > The Chardev events are listed in the QEMUChrEvent enum. To be > able to use this enum in the IOEventHandler typedef, we need to > explicit when frontends ignore some events, to silent GCC the > following warnings: > > CC monitor/hmp.o > monitor/hmp.c: In function ‘monitor_event’: > monitor/hmp.c:1330:5: error: enumeration value ‘CHR_EVENT_BREAK’ not > handled in switch [-Werror=switch] > 1330 | switch (event) { > | ^~~~~~ > cc1: all warnings being treated as errors > > Signed-off-by: Philippe Mathieu-Daudé <[email protected]> > ---
Acked-by: Dr. David Alan Gilbert <[email protected]> for HMP Note that the use of 'default' will make life more unpredictable if you ever come to add a new event type. Dave > Cc: "Dr. David Alan Gilbert" <[email protected]> > --- > monitor/hmp.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/monitor/hmp.c b/monitor/hmp.c > index 8942e28933..d84238c120 100644 > --- a/monitor/hmp.c > +++ b/monitor/hmp.c > @@ -1371,6 +1371,10 @@ static void monitor_event(void *opaque, int event) > mon_refcount--; > monitor_fdsets_cleanup(); > break; > + > + default: > + /* Ignore */ > + break; > } > } > > -- > 2.21.0 > -- Dr. David Alan Gilbert / [email protected] / Manchester, UK
