Philippe Mathieu-Daudé <[email protected]> writes: > The Chardev events are listed in the QEMUChrEvent enum. To be > able to use this enum in the IOEventHandler typedef, we need to > explicit when frontends ignore some events, to silent GCC the > following warnings: > > CC s390x-softmmu/hw/char/terminal3270.o > hw/char/terminal3270.c: In function ‘chr_event’: > hw/char/terminal3270.c:156:5: error: enumeration value ‘CHR_EVENT_BREAK’ > not handled in switch [-Werror=switch] > 156 | switch (event) { > | ^~~~~~ > hw/char/terminal3270.c:156:5: error: enumeration value ‘CHR_EVENT_MUX_IN’ > not handled in switch [-Werror=switch] > hw/char/terminal3270.c:156:5: error: enumeration value ‘CHR_EVENT_MUX_OUT’ > not handled in switch [-Werror=switch] > cc1: all warnings being treated as errors > > Signed-off-by: Philippe Mathieu-Daudé <[email protected]> > --- > Cc: Cornelia Huck <[email protected]> > Cc: Halil Pasic <[email protected]> > Cc: Christian Borntraeger <[email protected]> > Cc: "Marc-André Lureau" <[email protected]> > Cc: Paolo Bonzini <[email protected]> > Cc: [email protected] > --- > hw/char/terminal3270.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/hw/char/terminal3270.c b/hw/char/terminal3270.c > index 6859c1bcb2..9e59a2d92b 100644 > --- a/hw/char/terminal3270.c > +++ b/hw/char/terminal3270.c > @@ -166,6 +166,9 @@ static void chr_event(void *opaque, int event) > sch->curr_status.scsw.dstat = SCSW_DSTAT_DEVICE_END; > css_conditional_io_interrupt(sch); > break; > + default: > + /* Ignore */ > + break; > } > }
I doubt the /* Ignore */ comment is worth its keep. Splitting PATCH 02-13 feels excessive to me.
