Patchew URL: https://patchew.org/QEMU/20200204095208.269131-1-k.jen...@samsung.com/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v5 00/26] nvme: support NVMe v1.3d, SGLs and multiple namespaces Message-id: 20200204095208.269131-1-k.jen...@samsung.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu * [new tag] patchew/20200204095208.269131-1-k.jen...@samsung.com -> patchew/20200204095208.269131-1-k.jen...@samsung.com Switched to a new branch 'test' a7128db nvme: make lba data size configurable a0eb0b5 nvme: remove redundant NvmeCmd pointer parameter 0e1bd8c nvme: change controller pci id f046db4 pci: allocate pci id for nvme a59d563 nvme: support multiple namespaces f6b57ba nvme: add support for scatter gather lists 4f78005 nvme: handle dma errors 4e75b11 pci: pass along the return value of dma_memory_rw c08065d nvme: use preallocated qsg/iov in nvme_dma_prp 3ec0d9f nvme: allow multiple aios per command 540b98f nvme: refactor prp mapping 8fd4e4c nvme: bump supported specification to 1.3 13fceab nvme: make sure ncqr and nsqr is valid 66bf321 nvme: additional tracing bbb3c58 nvme: add missing mandatory features 77b9455 nvme: add support for the asynchronous event request command 8cdc15c nvme: add support for the get log page command e612e83 nvme: add temperature threshold feature ffc039c nvme: refactor device realization 0623024 nvme: add support for the abort command 11b89df nvme: refactor nvme_addr_read d9f7bf0 nvme: populate the mandatory subnqn and ver fields f8716d6 nvme: add missing fields in the identify data structures 67d91b0 nvme: move device parameters to separate struct 5f71397 nvme: remove superfluous breaks f83d65c nvme: rename trace events to nvme_dev === OUTPUT BEGIN === 1/26 Checking commit f83d65c36a14 (nvme: rename trace events to nvme_dev) 2/26 Checking commit 5f71397a1057 (nvme: remove superfluous breaks) 3/26 Checking commit 67d91b03edce (nvme: move device parameters to separate struct) ERROR: Macros with complex values should be enclosed in parenthesis #177: FILE: hw/block/nvme.h:6: +#define DEFINE_NVME_PROPERTIES(_state, _props) \ + DEFINE_PROP_STRING("serial", _state, _props.serial), \ + DEFINE_PROP_UINT32("cmb_size_mb", _state, _props.cmb_size_mb, 0), \ + DEFINE_PROP_UINT32("num_queues", _state, _props.num_queues, 64) total: 1 errors, 0 warnings, 181 lines checked Patch 3/26 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/26 Checking commit f8716d6d577c (nvme: add missing fields in the identify data structures) 5/26 Checking commit d9f7bf0bea10 (nvme: populate the mandatory subnqn and ver fields) 6/26 Checking commit 11b89df75991 (nvme: refactor nvme_addr_read) 7/26 Checking commit 06230241911a (nvme: add support for the abort command) 8/26 Checking commit ffc039c6a990 (nvme: refactor device realization) 9/26 Checking commit e612e83d5189 (nvme: add temperature threshold feature) 10/26 Checking commit 8cdc15c88d53 (nvme: add support for the get log page command) 11/26 Checking commit 77b945573421 (nvme: add support for the asynchronous event request command) 12/26 Checking commit bbb3c586241a (nvme: add missing mandatory features) 13/26 Checking commit 66bf3218e7f3 (nvme: additional tracing) 14/26 Checking commit 13fceab275cc (nvme: make sure ncqr and nsqr is valid) 15/26 Checking commit 8fd4e4c6fb73 (nvme: bump supported specification to 1.3) 16/26 Checking commit 540b98f3c98d (nvme: refactor prp mapping) 17/26 Checking commit 3ec0d9f718ea (nvme: allow multiple aios per command) 18/26 Checking commit c08065deefa3 (nvme: use preallocated qsg/iov in nvme_dma_prp) 19/26 Checking commit 4e75b1170a2f (pci: pass along the return value of dma_memory_rw) 20/26 Checking commit 4f78005aa73f (nvme: handle dma errors) 21/26 Checking commit f6b57ba3f3f8 (nvme: add support for scatter gather lists) 22/26 Checking commit a59d5630a44f (nvme: support multiple namespaces) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: Macros with complex values should be enclosed in parenthesis #218: FILE: hw/block/nvme-ns.h:8: +#define DEFINE_NVME_NS_PROPERTIES(_state, _props) \ + DEFINE_PROP_DRIVE("drive", _state, blk), \ + DEFINE_PROP_UINT32("nsid", _state, _props.nsid, 0) total: 1 errors, 1 warnings, 816 lines checked Patch 22/26 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 23/26 Checking commit f046db41f34b (pci: allocate pci id for nvme) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #29: new file mode 100644 total: 0 errors, 1 warnings, 31 lines checked Patch 23/26 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 24/26 Checking commit 0e1bd8c8281e (nvme: change controller pci id) 25/26 Checking commit a0eb0b55ad5d (nvme: remove redundant NvmeCmd pointer parameter) 26/26 Checking commit a7128db3f7bf (nvme: make lba data size configurable) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200204095208.269131-1-k.jen...@samsung.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
