Hi,

On 26 May 2011 18:34, Peter Maydell <peter.mayd...@linaro.org> wrote:
> The 9118 ethernet controller interrupt line is active low unless
> the IRQ config register is programmed to set both the IRQ_POL
> (polarity: active-high) and IRQ_TYPE (type: push-pull) bits:
> implement support for inverting the irq output in other configurations.
> This also requires that we support setting the bits in the first
> place, and that we correctly preserve them across software reset.
>
> Signed-off-by: Peter Maydell <peter.mayd...@linaro.org>
> ---
> The motivation for this patch is actually an omap3 platform (overo)
> which uses the active-low configuration; the platforms in QEMU
> mainline which use it (vexpress and realview) both configure the
> chip to active-high, which is why this bug hasn't come to light
> before. I've tested that (a) my overo platform works with the
> change and (b) it doesn't regress vexpress.

I pushed this patch, thanks.

Cheers

Reply via email to