Patchew URL: https://patchew.org/QEMU/20200212130311.127515-1-ys...@users.sourceforge.jp/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v30 00/22] Add RX archtecture support Message-id: 20200212130311.127515-1-ys...@users.sourceforge.jp Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu - [tag update] patchew/20200212130311.127515-1-ys...@users.sourceforge.jp -> patchew/20200212130311.127515-1-ys...@users.sourceforge.jp Switched to a new branch 'test' b99dc82 qemu-doc.texi: Add RX section. 0d81589 BootLinuxConsoleTest: Test the RX-Virt machine e1fb98f Add rx-softmmu 9fb7102 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core 3491db9 hw/rx: Honor -accel qtest 7905f70 hw/rx: RX Target hardware definition 6871a28 hw/char: RX62N serial communication interface (SCI) 430e7ae hw/timer: RX62N internal timer modules 029f7c2 hw/intc: RX62N interrupt controller (ICUa) 08436a0 target/rx: Dump bytes for each insn during disassembly 0922998 target/rx: Collect all bytes during disassembly f7c9eeb target/rx: Emit all disassembly in one prt() b26c962 target/rx: Use prt_ldmi for XCHG_mr disassembly 547cba7 target/rx: Replace operand with prt_ldmi in disassembler 72fdb0c target/rx: Disassemble rx_index_addr into a string 9ae47c8 target/rx: RX disassembler 6ce9166 target/rx: CPU definition f44b93f target/rx: TCG helper d12c2b0 target/rx: TCG translation 4765cee hw/registerfields.h: Add 8bit and 16bit register macros d8bef98 qemu/bitops.h: Add extract8 and extract16 3b29a0a MAINTAINERS: Add RX === OUTPUT BEGIN === 1/22 Checking commit 3b29a0a2c13b (MAINTAINERS: Add RX) 2/22 Checking commit d8bef9867414 (qemu/bitops.h: Add extract8 and extract16) 3/22 Checking commit 4765cee62a1b (hw/registerfields.h: Add 8bit and 16bit register macros) Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2490. ERROR: Macros with multiple statements should be enclosed in a do - while loop #27: FILE: include/hw/registerfields.h:25: +#define REG8(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) }; ERROR: Macros with multiple statements should be enclosed in a do - while loop #31: FILE: include/hw/registerfields.h:29: +#define REG16(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) / 2 }; total: 2 errors, 0 warnings, 56 lines checked Patch 3/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/22 Checking commit d12c2b05dc64 (target/rx: TCG translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 3065 lines checked Patch 4/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/22 Checking commit f44b93fefa39 (target/rx: TCG helper) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 total: 0 errors, 1 warnings, 650 lines checked Patch 5/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/22 Checking commit 6ce916678c4b (target/rx: CPU definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #22: new file mode 100644 total: 0 errors, 1 warnings, 659 lines checked Patch 6/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/22 Checking commit 9ae47c83cd99 (target/rx: RX disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 1497 lines checked Patch 7/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/22 Checking commit 72fdb0cf8e02 (target/rx: Disassemble rx_index_addr into a string) 9/22 Checking commit 547cba7fec67 (target/rx: Replace operand with prt_ldmi in disassembler) 10/22 Checking commit b26c962f1e11 (target/rx: Use prt_ldmi for XCHG_mr disassembly) 11/22 Checking commit f7c9eebd32fb (target/rx: Emit all disassembly in one prt()) 12/22 Checking commit 0922998c8ca2 (target/rx: Collect all bytes during disassembly) 13/22 Checking commit 08436a08ece7 (target/rx: Dump bytes for each insn during disassembly) 14/22 Checking commit 029f7c293c53 (hw/intc: RX62N interrupt controller (ICUa)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 total: 0 errors, 1 warnings, 445 lines checked Patch 14/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/22 Checking commit 430e7ae5bc53 (hw/timer: RX62N internal timer modules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 total: 0 errors, 1 warnings, 845 lines checked Patch 15/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/22 Checking commit 6871a2859564 (hw/char: RX62N serial communication interface (SCI)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 400 lines checked Patch 16/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/22 Checking commit 7905f70a12a1 (hw/rx: RX Target hardware definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #23: new file mode 100644 ERROR: trailing whitespace #128: FILE: hw/rx/rx-virt.c:73: + $ ERROR: trailing whitespace #146: FILE: hw/rx/rx-virt.c:91: + /* The kernel image is loaded into $ WARNING: Block comments use a leading /* on a separate line #146: FILE: hw/rx/rx-virt.c:91: + /* The kernel image is loaded into WARNING: Block comments use * on subsequent lines #147: FILE: hw/rx/rx-virt.c:92: + /* The kernel image is loaded into + the latter half of the SDRAM space. */ WARNING: Block comments use a trailing */ on a separate line #147: FILE: hw/rx/rx-virt.c:92: + the latter half of the SDRAM space. */ total: 2 errors, 4 warnings, 493 lines checked Patch 17/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/22 Checking commit 3491db96714e (hw/rx: Honor -accel qtest) 19/22 Checking commit 9fb7102e2ee2 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core) 20/22 Checking commit e1fb98f90c3b (Add rx-softmmu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #69: new file mode 100644 total: 0 errors, 1 warnings, 83 lines checked Patch 20/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/22 Checking commit 0d81589f7682 (BootLinuxConsoleTest: Test the RX-Virt machine) 22/22 Checking commit b99dc821dcb8 (qemu-doc.texi: Add RX section.) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200212130311.127515-1-ys...@users.sourceforge.jp/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com