Patchew URL: https://patchew.org/QEMU/20200212130311.127515-1-ys...@users.sourceforge.jp/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v30 00/22] Add RX archtecture support Message-id: 20200212130311.127515-1-ys...@users.sourceforge.jp Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu - [tag update] patchew/20200212130311.127515-1-ys...@users.sourceforge.jp -> patchew/20200212130311.127515-1-ys...@users.sourceforge.jp Switched to a new branch 'test' 4470895 qemu-doc.texi: Add RX section. f0b23ed BootLinuxConsoleTest: Test the RX-Virt machine 92a7207 Add rx-softmmu e3ec889 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core b62a7e2 hw/rx: Honor -accel qtest ecdf913 hw/rx: RX Target hardware definition a7637c5 hw/char: RX62N serial communication interface (SCI) 3f8b83c hw/timer: RX62N internal timer modules f2c5f71 hw/intc: RX62N interrupt controller (ICUa) 66902a4 target/rx: Dump bytes for each insn during disassembly 691260f target/rx: Collect all bytes during disassembly 7b77f1a target/rx: Emit all disassembly in one prt() ced96c7 target/rx: Use prt_ldmi for XCHG_mr disassembly e24ee8d target/rx: Replace operand with prt_ldmi in disassembler cc5ad57 target/rx: Disassemble rx_index_addr into a string db3bdeb target/rx: RX disassembler b3d7bf4 target/rx: CPU definition 936ddc4 target/rx: TCG helper 2e5e44d target/rx: TCG translation 303744a hw/registerfields.h: Add 8bit and 16bit register macros 767e9e6 qemu/bitops.h: Add extract8 and extract16 c576bd7 MAINTAINERS: Add RX === OUTPUT BEGIN === 1/22 Checking commit c576bd79d68d (MAINTAINERS: Add RX) 2/22 Checking commit 767e9e6adb78 (qemu/bitops.h: Add extract8 and extract16) 3/22 Checking commit 303744a62af8 (hw/registerfields.h: Add 8bit and 16bit register macros) Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2490. ERROR: Macros with multiple statements should be enclosed in a do - while loop #27: FILE: include/hw/registerfields.h:25: +#define REG8(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) }; ERROR: Macros with multiple statements should be enclosed in a do - while loop #31: FILE: include/hw/registerfields.h:29: +#define REG16(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) / 2 }; total: 2 errors, 0 warnings, 56 lines checked Patch 3/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/22 Checking commit 2e5e44dcfc69 (target/rx: TCG translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 3065 lines checked Patch 4/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/22 Checking commit 936ddc4f1b14 (target/rx: TCG helper) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 total: 0 errors, 1 warnings, 650 lines checked Patch 5/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/22 Checking commit b3d7bf4ef6ae (target/rx: CPU definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #22: new file mode 100644 total: 0 errors, 1 warnings, 659 lines checked Patch 6/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/22 Checking commit db3bdeb0a4bf (target/rx: RX disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 1497 lines checked Patch 7/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/22 Checking commit cc5ad57c2c56 (target/rx: Disassemble rx_index_addr into a string) 9/22 Checking commit e24ee8d89615 (target/rx: Replace operand with prt_ldmi in disassembler) 10/22 Checking commit ced96c73a4f4 (target/rx: Use prt_ldmi for XCHG_mr disassembly) 11/22 Checking commit 7b77f1ab7077 (target/rx: Emit all disassembly in one prt()) 12/22 Checking commit 691260ffe7fa (target/rx: Collect all bytes during disassembly) 13/22 Checking commit 66902a40736b (target/rx: Dump bytes for each insn during disassembly) 14/22 Checking commit f2c5f711f5ac (hw/intc: RX62N interrupt controller (ICUa)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 total: 0 errors, 1 warnings, 445 lines checked Patch 14/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/22 Checking commit 3f8b83c03e1d (hw/timer: RX62N internal timer modules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 total: 0 errors, 1 warnings, 845 lines checked Patch 15/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/22 Checking commit a7637c5043f1 (hw/char: RX62N serial communication interface (SCI)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 400 lines checked Patch 16/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/22 Checking commit ecdf913ebc5b (hw/rx: RX Target hardware definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #23: new file mode 100644 ERROR: trailing whitespace #128: FILE: hw/rx/rx-virt.c:73: + $ ERROR: trailing whitespace #146: FILE: hw/rx/rx-virt.c:91: + /* The kernel image is loaded into $ WARNING: Block comments use a leading /* on a separate line #146: FILE: hw/rx/rx-virt.c:91: + /* The kernel image is loaded into WARNING: Block comments use * on subsequent lines #147: FILE: hw/rx/rx-virt.c:92: + /* The kernel image is loaded into + the latter half of the SDRAM space. */ WARNING: Block comments use a trailing */ on a separate line #147: FILE: hw/rx/rx-virt.c:92: + the latter half of the SDRAM space. */ total: 2 errors, 4 warnings, 493 lines checked Patch 17/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/22 Checking commit b62a7e22a70c (hw/rx: Honor -accel qtest) 19/22 Checking commit e3ec88947610 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core) 20/22 Checking commit 92a72077979d (Add rx-softmmu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #69: new file mode 100644 total: 0 errors, 1 warnings, 83 lines checked Patch 20/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/22 Checking commit f0b23edc7d0a (BootLinuxConsoleTest: Test the RX-Virt machine) 22/22 Checking commit 44708958d5b5 (qemu-doc.texi: Add RX section.) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200212130311.127515-1-ys...@users.sourceforge.jp/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
