Patchew URL: https://patchew.org/QEMU/20200223065102.61652-1-ys...@users.sourceforge.jp/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v31 00/22] Add RX archtecture support Message-id: 20200223065102.61652-1-ys...@users.sourceforge.jp Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu * [new tag] patchew/20200223065102.61652-1-ys...@users.sourceforge.jp -> patchew/20200223065102.61652-1-ys...@users.sourceforge.jp Switched to a new branch 'test' 98aae80 qemu-doc.texi: Add RX section. c084aad BootLinuxConsoleTest: Test the RX-Virt machine d38442f Add rx-softmmu b518869 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core 3649961 hw/rx: Honor -accel qtest a354c0e hw/rx: RX Target hardware definition 279d917 hw/char: RX62N serial communication interface (SCI) 47f494d hw/timer: RX62N internal timer modules f92e9ad hw/intc: RX62N interrupt controller (ICUa) 08a2021 target/rx: Dump bytes for each insn during disassembly 18cbc61 target/rx: Collect all bytes during disassembly accb127 target/rx: Emit all disassembly in one prt() 7819841 target/rx: Use prt_ldmi for XCHG_mr disassembly d2a8b8d target/rx: Replace operand with prt_ldmi in disassembler 5281766 target/rx: Disassemble rx_index_addr into a string 1c44ec2 target/rx: RX disassembler 28cd499 target/rx: CPU definition 7128a45 target/rx: TCG helper a6df174 target/rx: TCG translation bed06eb hw/registerfields.h: Add 8bit and 16bit register macros 862b2a3 qemu/bitops.h: Add extract8 and extract16 aa57148 MAINTAINERS: Add RX === OUTPUT BEGIN === 1/22 Checking commit aa5714805044 (MAINTAINERS: Add RX) 2/22 Checking commit 862b2a3f68b6 (qemu/bitops.h: Add extract8 and extract16) 3/22 Checking commit bed06eb00edb (hw/registerfields.h: Add 8bit and 16bit register macros) Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2495. ERROR: Macros with multiple statements should be enclosed in a do - while loop #27: FILE: include/hw/registerfields.h:25: +#define REG8(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) }; ERROR: Macros with multiple statements should be enclosed in a do - while loop #31: FILE: include/hw/registerfields.h:29: +#define REG16(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) / 2 }; total: 2 errors, 0 warnings, 56 lines checked Patch 3/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/22 Checking commit a6df17471dbc (target/rx: TCG translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 3065 lines checked Patch 4/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/22 Checking commit 7128a45b6a9b (target/rx: TCG helper) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 total: 0 errors, 1 warnings, 650 lines checked Patch 5/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/22 Checking commit 28cd4994482f (target/rx: CPU definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #22: new file mode 100644 total: 0 errors, 1 warnings, 659 lines checked Patch 6/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/22 Checking commit 1c44ec22dd4a (target/rx: RX disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 1497 lines checked Patch 7/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/22 Checking commit 5281766b6573 (target/rx: Disassemble rx_index_addr into a string) 9/22 Checking commit d2a8b8d65cbe (target/rx: Replace operand with prt_ldmi in disassembler) 10/22 Checking commit 7819841c2e13 (target/rx: Use prt_ldmi for XCHG_mr disassembly) 11/22 Checking commit accb127df60f (target/rx: Emit all disassembly in one prt()) 12/22 Checking commit 18cbc6142921 (target/rx: Collect all bytes during disassembly) 13/22 Checking commit 08a20215da87 (target/rx: Dump bytes for each insn during disassembly) 14/22 Checking commit f92e9adb3005 (hw/intc: RX62N interrupt controller (ICUa)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 total: 0 errors, 1 warnings, 445 lines checked Patch 14/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/22 Checking commit 47f494d3393d (hw/timer: RX62N internal timer modules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 total: 0 errors, 1 warnings, 845 lines checked Patch 15/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/22 Checking commit 279d91729697 (hw/char: RX62N serial communication interface (SCI)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 400 lines checked Patch 16/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/22 Checking commit a354c0e0a816 (hw/rx: RX Target hardware definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #23: new file mode 100644 WARNING: Block comments use a leading /* on a separate line #146: FILE: hw/rx/rx-virt.c:91: + /* The kernel image is loaded into WARNING: Block comments use * on subsequent lines #147: FILE: hw/rx/rx-virt.c:92: + /* The kernel image is loaded into + the latter half of the SDRAM space. */ WARNING: Block comments use a trailing */ on a separate line #147: FILE: hw/rx/rx-virt.c:92: + the latter half of the SDRAM space. */ total: 0 errors, 4 warnings, 493 lines checked Patch 17/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/22 Checking commit 3649961b949a (hw/rx: Honor -accel qtest) 19/22 Checking commit b518869e57de (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core) 20/22 Checking commit d38442f1d1da (Add rx-softmmu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #69: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 20/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/22 Checking commit c084aad40172 (BootLinuxConsoleTest: Test the RX-Virt machine) 22/22 Checking commit 98aae803957c (qemu-doc.texi: Add RX section.) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200223065102.61652-1-ys...@users.sourceforge.jp/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com