Patchew URL: https://patchew.org/QEMU/[email protected]/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v31 00/22] Add RX archtecture support Message-id: [email protected] Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu - [tag update] patchew/[email protected] -> patchew/[email protected] Switched to a new branch 'test' 207fda1 qemu-doc.texi: Add RX section. 1d2f2ed BootLinuxConsoleTest: Test the RX-Virt machine de2e11e Add rx-softmmu 534f2cc hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core 5ced9d2 hw/rx: Honor -accel qtest 63f4519 hw/rx: RX Target hardware definition 95ec5ac hw/char: RX62N serial communication interface (SCI) f087bf6 hw/timer: RX62N internal timer modules 9c1d3ea hw/intc: RX62N interrupt controller (ICUa) 3064ee8 target/rx: Dump bytes for each insn during disassembly d95bde1 target/rx: Collect all bytes during disassembly 4cf6a3b target/rx: Emit all disassembly in one prt() 256823f target/rx: Use prt_ldmi for XCHG_mr disassembly 67672ed target/rx: Replace operand with prt_ldmi in disassembler dc31fb3 target/rx: Disassemble rx_index_addr into a string 01690ad target/rx: RX disassembler f30ec96 target/rx: CPU definition d2d394c target/rx: TCG helper 35f89fa target/rx: TCG translation 0306f20 hw/registerfields.h: Add 8bit and 16bit register macros 8750517 qemu/bitops.h: Add extract8 and extract16 8e03a10 MAINTAINERS: Add RX === OUTPUT BEGIN === 1/22 Checking commit 8e03a1004db2 (MAINTAINERS: Add RX) 2/22 Checking commit 875051703f0c (qemu/bitops.h: Add extract8 and extract16) 3/22 Checking commit 0306f201fabd (hw/registerfields.h: Add 8bit and 16bit register macros) Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2495. ERROR: Macros with multiple statements should be enclosed in a do - while loop #27: FILE: include/hw/registerfields.h:25: +#define REG8(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) }; ERROR: Macros with multiple statements should be enclosed in a do - while loop #31: FILE: include/hw/registerfields.h:29: +#define REG16(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) / 2 }; total: 2 errors, 0 warnings, 56 lines checked Patch 3/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/22 Checking commit 35f89fa2be21 (target/rx: TCG translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 3065 lines checked Patch 4/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/22 Checking commit d2d394c6b3fa (target/rx: TCG helper) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 total: 0 errors, 1 warnings, 650 lines checked Patch 5/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/22 Checking commit f30ec963e940 (target/rx: CPU definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #22: new file mode 100644 total: 0 errors, 1 warnings, 659 lines checked Patch 6/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/22 Checking commit 01690adab631 (target/rx: RX disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 1497 lines checked Patch 7/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/22 Checking commit dc31fb3d7505 (target/rx: Disassemble rx_index_addr into a string) 9/22 Checking commit 67672edb237b (target/rx: Replace operand with prt_ldmi in disassembler) 10/22 Checking commit 256823f4a9c3 (target/rx: Use prt_ldmi for XCHG_mr disassembly) 11/22 Checking commit 4cf6a3b12d30 (target/rx: Emit all disassembly in one prt()) 12/22 Checking commit d95bde1169a7 (target/rx: Collect all bytes during disassembly) 13/22 Checking commit 3064ee8af26b (target/rx: Dump bytes for each insn during disassembly) 14/22 Checking commit 9c1d3ea50c50 (hw/intc: RX62N interrupt controller (ICUa)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 total: 0 errors, 1 warnings, 445 lines checked Patch 14/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/22 Checking commit f087bf6f0a35 (hw/timer: RX62N internal timer modules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 total: 0 errors, 1 warnings, 845 lines checked Patch 15/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/22 Checking commit 95ec5acdf76b (hw/char: RX62N serial communication interface (SCI)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 400 lines checked Patch 16/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/22 Checking commit 63f45194b77b (hw/rx: RX Target hardware definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #23: new file mode 100644 WARNING: Block comments use a leading /* on a separate line #146: FILE: hw/rx/rx-virt.c:91: + /* The kernel image is loaded into WARNING: Block comments use * on subsequent lines #147: FILE: hw/rx/rx-virt.c:92: + /* The kernel image is loaded into + the latter half of the SDRAM space. */ WARNING: Block comments use a trailing */ on a separate line #147: FILE: hw/rx/rx-virt.c:92: + the latter half of the SDRAM space. */ total: 0 errors, 4 warnings, 493 lines checked Patch 17/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/22 Checking commit 5ced9d2932a6 (hw/rx: Honor -accel qtest) 19/22 Checking commit 534f2cc37de4 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core) 20/22 Checking commit de2e11e8dc10 (Add rx-softmmu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #69: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 20/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/22 Checking commit 1d2f2ed13686 (BootLinuxConsoleTest: Test the RX-Virt machine) 22/22 Checking commit 207fda1ae52a (qemu-doc.texi: Add RX section.) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/[email protected]/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to [email protected]
