23.06.2011 16:00, Richard W.M. Jones wrote: > On Thu, Jun 23, 2011 at 05:18:57PM +0800, Wayne Xia wrote: >> Hi, >> these 3 patch simply enable qemu-kvm to show a logo picture when it >> s start up, following is how to configurate it: >> invoke it with params: >> -boot (splash_time=<N>,) (splash_filename=<N>,) >> the splash_time is in the unit of ms, and its max value is 65535. >> this feature is by default on with 5000ms showing up. >> Patch 1 contains the source modification for qemu-kvm, Patch 2 and >> 3 are binary patches that added a default logo picture file, alternated >> the bios.bin to make the sea-bios showing it. Patch 3 is just used to >> provide a convenient way to test the Patch, waiting for newer version >> of seabios that provide the support officially. >> Any comments would be very nice. > > Splash screens are a terrible idea. We should work instead on making > the boot even faster.
I completely agree. Qemu does not do much in the BIOS (as a regular PC does while initializing various devices, reading boot records and so on), so there's nothing to hide here (except of problem reports in case of trouble - it's already waaay more than enough when people use -daemonize option which effectively turns off stderr). While booting the system it's possible to have its own splash screen if desirable. But the whole thing is somewhat moot for qemu anyway: just start whole thing in background. > Please don't accept these patches. *nod* /mjt
