On Thu, Jun 23, 2011 at 01:24:01PM +0200, Jan Kiszka wrote: > On 2011-06-23 13:20, Wayne Xia wrote: > > 2011-6-23 18:03, Jan Kiszka > >> On 2011-06-23 11:18, Wayne Xia wrote: > >>> Hi, > >>> these 3 patch simply enable qemu-kvm to show a logo picture when it > >> > >> You are posting on qemu-devel (which is correct for this topic), so your > >> patches must target that tree. Patch 1 eg. does not and needs rebasing. > >> > > thanks for the tip. > >>> s start up, following is how to configurate it: > >>> invoke it with params: > >>> -boot (splash_time=<N>,) (splash_filename=<N>,) > >> > >> Simply 'splash' for specifying the file should suffice. > >> > >>> the splash_time is in the unit of ms, and its max value is 65535. > >>> this feature is by default on with 5000ms showing up. > >> > >> Strong NAK for making this default. We have a nice sub-second BIOS time > >> in QEMU, and that must not be destroyed by eye candy. 5 s is also way > >> too long even when you want splash. > >> > > Maybe 5 is a bit too long, this patch is for test so made it a bit > > longer to be observed by VNC, I think 2.5s would be fit. > > Maybe it could be something like that if the user specifies a splash > file - which indicates that there should be some splash delay as well. > Default without any splash parameter must remain 0, ie. disabled.
I don't think you want to change default timeouts based on whether a splash screen is present. Consider that if you have enabled PXE boot on one of the guest NICs, then there is already a few second delay while the BIOS PXEs, during which it QEMU would be showing the splash screen. You don't then want to add a further 2.5s or 5s delay ontop of that already imposed by the BIOS PXE process. Just let the splash screen be displayed for however long the BIOS process takes, without any extra artifical delays, even if this is a mere fraction of a second in some cases. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
