On Fri, 3 Apr 2020 15:06:14 +0100 Peter Maydell <peter.mayd...@linaro.org> wrote:
> On Fri, 3 Apr 2020 at 15:00, Igor Mammedov <imamm...@redhat.com> wrote: > > > > Fixes: 3f350f6bb36233be50fc2bc18dc78b6a948a5dbe > > Reported-by: Peter Maydell <peter.mayd...@linaro.org> > > Signed-off-by: Igor Mammedov <imamm...@redhat.com> > > --- > > include/qemu/nvdimm-utils.h | 2 -- > > util/nvdimm-utils.c | 29 +++++++++++++++++++++++++++++ > > 2 files changed, 29 insertions(+), 2 deletions(-) > > > > diff --git a/include/qemu/nvdimm-utils.h b/include/qemu/nvdimm-utils.h > > index 4b8b198ba7..1f1dae477f 100644 > > --- a/include/qemu/nvdimm-utils.h > > +++ b/include/qemu/nvdimm-utils.h > > @@ -1,7 +1,5 @@ > > #ifndef NVDIMM_UTILS_H > > #define NVDIMM_UTILS_H > > > > .h file still missing the copyright-n-license comment ? do we have to add that for headers as well? > > > -#include "qemu/osdep.h" > > - > > GSList *nvdimm_get_device_list(void); > > #endif > > diff --git a/util/nvdimm-utils.c b/util/nvdimm-utils.c > > index 5cc768ca47..ca41d39af5 100644 > > --- a/util/nvdimm-utils.c > > +++ b/util/nvdimm-utils.c > > @@ -1,3 +1,32 @@ > > +/* > > + * NVDIMM utilities > > + * > > + * Copyright(C) 2015 Intel Corporation. > > + * > > + * Author: > > + * Xiao Guangrong <guangrong.x...@linux.intel.com> > > + * > > + * NFIT is defined in ACPI 6.0: 5.2.25 NVDIMM Firmware Interface Table > > (NFIT) > > + * and the DSM specification can be found at: > > + * http://pmem.io/documents/NVDIMM_DSM_Interface_Example.pdf > > + * > > + * Currently, it only supports PMEM Virtualization. > > + * > > + * This library is free software; you can redistribute it and/or > > + * modify it under the terms of the GNU Lesser General Public > > + * License as published by the Free Software Foundation; either > > + * version 2 of the License, or (at your option) any later version. > > I guess you copied this from somewhere else, but commit b7cbb8741b40b7c > suggests that "Lesser General Public License version 2" is > wrong and it should either be "Library General Public License > version 2" or "Lesser General Public License version 2.1"...we > might as well get it right when we're adding a new file, so > I would suggest you want 2.1 here. it's copied from the source file this code was moved from. > > > + * > > + * This library is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > > + * Lesser General Public License for more details. > > + * > > + * You should have received a copy of the GNU Lesser General Public > > + * License along with this library; if not, see > > <http://www.gnu.org/licenses/> > > + */ > > + > > +#include "qemu/osdep.h" > > #include "qemu/nvdimm-utils.h" > > #include "hw/mem/nvdimm.h" > > > > -- > > 2.18.1 > > > > > thanks > -- PMM >