On Fri, 3 Apr 2020 at 15:13, Igor Mammedov <imamm...@redhat.com> wrote: > > On Fri, 3 Apr 2020 15:06:14 +0100 > Peter Maydell <peter.mayd...@linaro.org> wrote: > > > On Fri, 3 Apr 2020 at 15:00, Igor Mammedov <imamm...@redhat.com> wrote: > > > > > > Fixes: 3f350f6bb36233be50fc2bc18dc78b6a948a5dbe > > > Reported-by: Peter Maydell <peter.mayd...@linaro.org> > > > Signed-off-by: Igor Mammedov <imamm...@redhat.com> > > > --- > > > include/qemu/nvdimm-utils.h | 2 -- > > > util/nvdimm-utils.c | 29 +++++++++++++++++++++++++++++ > > > 2 files changed, 29 insertions(+), 2 deletions(-) > > > > > > diff --git a/include/qemu/nvdimm-utils.h b/include/qemu/nvdimm-utils.h > > > index 4b8b198ba7..1f1dae477f 100644 > > > --- a/include/qemu/nvdimm-utils.h > > > +++ b/include/qemu/nvdimm-utils.h > > > @@ -1,7 +1,5 @@ > > > #ifndef NVDIMM_UTILS_H > > > #define NVDIMM_UTILS_H > > > > > > > .h file still missing the copyright-n-license comment ? > do we have to add that for headers as well?
Yes; ideally every source file should state its license. thanks -- PMM