Patchew URL: https://patchew.org/QEMU/20200508230823.22956-1-wall...@linux.ibm.com/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200508230823.22956-1-wall...@linux.ibm.com Subject: [PATCH v1 0/8] s390: Extended-Length SCCB & DIAGNOSE 0x318 Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 101f5c5 s390: diagnose 318 info reset and migration support 07dbec2 s390/kvm: header sync for diag318 9985457 s390/sclp: add extended-length sccb support for kvm guest 8d13a8a s390/sclp: use cpu offset to locate cpu entries 4d17516 s390/sclp: read sccb from mem based on sccb length 4a1b469 s390/sclp: rework sclp boundary and length checks 699f978 s390/sclp: check sccb len before filling in data e4476cc s390/sclp: remove SCLPDevice param from prepare_cpu_entries === OUTPUT BEGIN === 1/8 Checking commit e4476ccd2e2b (s390/sclp: remove SCLPDevice param from prepare_cpu_entries) 2/8 Checking commit 699f978f26e8 (s390/sclp: check sccb len before filling in data) WARNING: line over 80 characters #22: FILE: hw/s390x/sclp.c:79: + if (be16_to_cpu(sccb->h.length) < (sizeof(ReadInfo) + cpu_count * sizeof(CPUEntry))) { ERROR: line over 90 characters #47: FILE: hw/s390x/sclp.c:137: + if (be16_to_cpu(sccb->h.length) < (sizeof(ReadCpuInfo) + cpu_count * sizeof(CPUEntry))) { WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #67: new file mode 100644 total: 1 errors, 2 warnings, 45 lines checked Patch 2/8 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/8 Checking commit 4a1b469bbbcb (s390/sclp: rework sclp boundary and length checks) 4/8 Checking commit 4d17516859c5 (s390/sclp: read sccb from mem based on sccb length) 5/8 Checking commit 8d13a8a15966 (s390/sclp: use cpu offset to locate cpu entries) 6/8 Checking commit 9985457a4f23 (s390/sclp: add extended-length sccb support for kvm guest) WARNING: line over 80 characters #87: FILE: hw/s390x/sclp.c:128: + warn_report("insufficient sccb size to store full read scp info response"); WARNING: line over 80 characters #111: FILE: target/s390x/cpu_features_def.inc.h:100: +DEF_FEAT(EXTENDED_LENGTH_SCCB, "els", STFL, 140, "Extended-length SCCB facility") total: 0 errors, 2 warnings, 74 lines checked Patch 6/8 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/8 Checking commit 07dbec216007 (s390/kvm: header sync for diag318) 8/8 Checking commit 101f5c56e483 (s390: diagnose 318 info reset and migration support) WARNING: line over 80 characters #219: FILE: target/s390x/cpu_features_def.inc.h:126: +DEF_FEAT(DIAG318, "diag318", SCLP_BYTE_134, 0, "Control program name and version codes") total: 0 errors, 1 warnings, 255 lines checked Patch 8/8 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200508230823.22956-1-wall...@linux.ibm.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com