On 09.05.20 01:08, Collin Walling wrote: > The SCCB must be checked for a sufficient length before it is filled > with any data. If the length is insufficient, then the SCLP command > is suppressed and the proper response code is set in the SCCB header. > > Signed-off-by: Collin Walling <wall...@linux.ibm.com> > --- > hw/s390x/sclp.c | 22 ++++++++++------------ > smp.max_cpus | 0 > 2 files changed, 10 insertions(+), 12 deletions(-) > create mode 100644 smp.max_cpus > > diff --git a/hw/s390x/sclp.c b/hw/s390x/sclp.c > index 156ffe3223..d08a291e40 100644 > --- a/hw/s390x/sclp.c > +++ b/hw/s390x/sclp.c > @@ -76,6 +76,11 @@ static void read_SCP_info(SCLPDevice *sclp, SCCB *sccb) > int rnsize, rnmax; > IplParameterBlock *ipib = s390_ipl_get_iplb(); > > + if (be16_to_cpu(sccb->h.length) < (sizeof(ReadInfo) + cpu_count * > sizeof(CPUEntry))) { > + sccb->h.response_code = > cpu_to_be16(SCLP_RC_INSUFFICIENT_SCCB_LENGTH); > + return; > + } > +
Lines too long. Please run scripts/checkpatch.pl before submitting. -- Thanks, David / dhildenb