On Mon, 11 May 2020 at 14:13, Patrick Williams <patr...@stwcx.xyz> wrote: > > On Mon, May 11, 2020 at 11:54:42AM +0100, Peter Maydell wrote: > > On Wed, 6 May 2020 at 19:32, Patrick Williams <patr...@stwcx.xyz> wrote: > > > Looking up through the thread I can't find the email where > > Amithash gave his reviewed-by tag -- did I miss it? > > I probably shouldn't have done this. I asked Amithash off-list for his > approval to add his Reviewed-by. I'll ask him to reply to this with > confirmation.
Thanks; no big deal. I figured I'd check because the details of how we handle reviewed-by tags are a bit non-obvious if you haven't worked with projects like QEMU or the kernel that use this email-based workflow before. > > PS: for the future, v2/v3 etc patches should be sent as > > fresh emails, not as followups/replies to the v1. > > Thanks. I missed this detail when I read [1] before but I see it now. > It seems like LKML tends to do the opposite? I don't do kernel development but AIUI they have the same general approach we do. Their process doc: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst#n771 says: "for a multi-patch series, it is generally best to avoid using In-Reply-To: to link to older versions of the series. This way multiple versions of the patch don't become an unmanageable forest of references in email clients." thanks -- PMM