On Tue, Jun 28, 2011 at 06:53:21PM +0200, Lluís wrote: > Move the 'st_print_trace_events' and 'st_change_trace_event_state' into > backend-agnostic 'trace_print_events' and 'trace_event_set_state' > (respectively) > in the "trace/control.c" file.
Renaming the functions makes sense but moving their implementations out into control.c inside an #ifdef is not clean. Why not keep their implementations in simple.c? Just renaming them to the generic name should be enough. Let the linker do the #ifdef (we only link in simple.o or we link in another trace backend). There's no need for control.c. Stefan
