Alistair Francis <alistai...@gmail.com> writes: > On Mon, May 18, 2020 at 10:08 PM Markus Armbruster <arm...@redhat.com> wrote: >> >> Alistair Francis <alistai...@gmail.com> writes: >> >> > On Sun, May 17, 2020 at 10:06 PM Markus Armbruster <arm...@redhat.com> >> > wrote: >> >> >> >> stm32f405_soc_initfn() creates six such devices, but >> >> stm32f405_soc_realize() realizes only one. Affects machine >> >> netduinoplus2. >> >> >> >> I wonder how this ever worked. If the "device becomes real only on >> >> realize" thing actually works, then we've always been missing five of >> >> six such devices, yet nobody noticed. >> > >> > I must have just been testing the first ADC. >> > >> >> >> >> Fix stm32f405_soc_realize() to realize all six. Visible in "info >> >> qtree": >> >> >> >> bus: main-system-bus >> >> type System >> >> dev: stm32f405-soc, id "" >> >> cpu-type = "cortex-m4-arm-cpu" >> >> dev: stm32f2xx-adc, id "" >> >> gpio-out "sysbus-irq" 1 >> >> - mmio ffffffffffffffff/00000000000000ff >> >> + mmio 0000000040012000/00000000000000ff >> >> dev: stm32f2xx-adc, id "" >> >> gpio-out "sysbus-irq" 1 >> >> - mmio ffffffffffffffff/00000000000000ff >> >> + mmio 0000000040012000/00000000000000ff >> >> dev: stm32f2xx-adc, id "" >> >> gpio-out "sysbus-irq" 1 >> >> - mmio ffffffffffffffff/00000000000000ff >> >> + mmio 0000000040012000/00000000000000ff >> >> dev: stm32f2xx-adc, id "" >> >> gpio-out "sysbus-irq" 1 >> >> - mmio ffffffffffffffff/00000000000000ff >> >> + mmio 0000000040012000/00000000000000ff >> >> dev: stm32f2xx-adc, id "" >> >> gpio-out "sysbus-irq" 1 >> >> mmio 0000000040012000/00000000000000ff >> >> dev: stm32f2xx-adc, id "" >> >> gpio-out "sysbus-irq" 1 >> >> - mmio ffffffffffffffff/00000000000000ff >> >> + mmio 0000000040012000/00000000000000ff >> >> dev: armv7m, id "" >> >> >> >> The mmio addresses look suspicious. >> > >> > Good catch, thanks :) >> >> I'd love to squash in corrections, but I don't know the correct >> addresses. Can you help? > > Yep, thanks for squashing it in. > > The three addresses are: > > 0x40012000 > 0x40012100 > 0x40012200 > > and they all share interrupt number 18.
An the other three? There are six devices in total... > Let me know if you want me to do it.
