On Tue, May 19, 2020 at 08:20:21PM +0200, Philippe Mathieu-Daudé wrote: > The 'blob_id' argument refers to a QOM object able to produce > data consumable by the fw_cfg device. The producer object must > implement the FW_CFG_DATA_GENERATOR interface. > > Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com> > --- > softmmu/vl.c | 17 +++++++++++++---- > 1 file changed, 13 insertions(+), 4 deletions(-) > > diff --git a/softmmu/vl.c b/softmmu/vl.c > index ae5451bc23..f76c53ad2e 100644 > --- a/softmmu/vl.c > +++ b/softmmu/vl.c > @@ -489,6 +489,10 @@ static QemuOptsList qemu_fw_cfg_opts = { > .name = "string", > .type = QEMU_OPT_STRING, > .help = "Sets content of the blob to be inserted from a string", > + }, { > + .name = "blob_id", > + .type = QEMU_OPT_STRING, > + .help = "Sets id of the object generating fw_cfg blob to be > used", > },
<bikeshed> I wonder if "generator_id" or "gen_id" is more appropriate as the property name </bikeshed> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|