Re: [PATCH] qga: Use gethostname() instead of g_get_host_name()

[Michal Privoznik]

On 6/19/20 11:54 PM, Richard Henderson wrote:
On 6/16/20 1:34 AM, Michal Privoznik wrote:
+#ifndef G_OS_WIN32

Nit: positive tests are easier to reason with and extend than negative tests.
I would reverse these two blocks and use a positive test for windows.

Also, CONFIG_WIN32 is what we use elsewhere for this test.


r~


Fair enough. Do you want me to send v2 or is it something that committer 
can fix before merging?

Michal